Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Node-side metrics for asynchronous backing #6236

Closed
slumber opened this issue Nov 3, 2022 · 1 comment
Closed

Node-side metrics for asynchronous backing #6236

slumber opened this issue Nov 3, 2022 · 1 comment
Assignees

Comments

@slumber
Copy link
Contributor

slumber commented Nov 3, 2022

There're several places with a potential of being a hotspot. We should introduce metrics for them to aid debugging during the testing phase.
Namely:

if !update.deactivated.is_empty() {
// This has potential to be a hotspot.
prune_view_candidate_storage(view);

// Re-trigger previously failed requests again.
//
// This makes sense for several reasons, one simple example: if a hypothetical depth
// for an advertisement initially exceeded the limit and the candidate was included
// in a new leaf.
let maybe_unblocked = std::mem::take(&mut state.blocked_advertisements);
// Could be optimized to only sanity check new leaves.
request_unblocked_collations(sender, state, maybe_unblocked).await;

And maybe some more (@rphmeier ?)

@mrcnski
Copy link
Contributor

mrcnski commented Feb 13, 2023

Closed by #6549.

@mrcnski mrcnski closed this as completed Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants