Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add way to query back reserved nodes through JSON-RPC layer #8147

Closed
tomaka opened this issue Feb 18, 2021 · 2 comments · Fixed by #8704
Closed

Add way to query back reserved nodes through JSON-RPC layer #8147

tomaka opened this issue Feb 18, 2021 · 2 comments · Fixed by #8704
Assignees

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 18, 2021

Apparently some users want to be able to query back the reserved nodes that they passed through --reserved-nodes and added/removed through addReservedPeer and removeReservedPeer.

@h4x3rotab
Copy link
Contributor

h4x3rotab commented Feb 19, 2021

Indeed! Recently we are building a Substrate validator DevOps framework. We use addReservedPeer and removeReservedPeer to pair our nodes in the private network in a cluster, but there's no way to query the current reserved node list. It would be very useful.

Also chatted with @wpank about this idea. Quoted here:

There's the system_networkState call, which dumps a lot of networking info about the state of the network from the nodes point of view, and then the system_peers rpc call, which shows the current peers the node is connected to. I imagine the reserved status can probably be added to the system_peers rpc call as a bool - something like reservedPeer: true or something like that. If this is a feature that would be really useful, best to add an issue to substrate

@kpp kpp self-assigned this Apr 30, 2021
@ghost ghost closed this as completed in #8704 May 3, 2021
@tomaka
Copy link
Contributor Author

tomaka commented May 3, 2021

system_reservedPeers 🚀

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants