Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ambiguous env vars: WS_ENDPOINT, NODE_*_PATTERN #89

Closed
PierreBesson opened this issue Jul 12, 2023 · 1 comment
Closed

Rename ambiguous env vars: WS_ENDPOINT, NODE_*_PATTERN #89

PierreBesson opened this issue Jul 12, 2023 · 1 comment
Assignees

Comments

@PierreBesson
Copy link
Contributor

PierreBesson commented Jul 12, 2023

For historical reasons, some environment variables are badly named which makes adoption of the testnet-manager by other teams tedious, eg WS_ENDPOINT should be RELAY_CHAIN_RPC_URL.

Since paritytech/substrate#12663 we have both WS and HTTP on the same server so we should merge the configuration for the WS (NODE_WS_PATTERN) and HTTP (NODE_HTTP_PATTERN) pattern into a single: RPC_NODE_URL_PATTERN.

We should also use POD_NAME instead of NODE_NAME as it is more descriptive.

Other possible changes:

  • VALIDATORS_ROOT_SEED -> DERIVATION_ROOT_SEED to make it clear it is used as derivation for both validators and collators.
  • TESTNET_MANAGER_CONSENSUS -> RELAY_CHAIN_CONSENSUS
  • NETWORK_SS58_FORMAT -> RELAY_CHAIN_SS58_FORMAT (parachain can have a different ss58 format)

Question: should we prefix all env vars by MANAGER_ ?

@PierreBesson PierreBesson changed the title Merge NODE_HTTP_PATTERN and NODE_WS_PATTERN into RPC_NODE_URL_PATTERN Rename ambiguous env vars: WS_ENDPOINT, NODE_*_PATTERN Jul 12, 2023
@lazam lazam closed this as completed Aug 29, 2023
@lazam
Copy link
Contributor

lazam commented Aug 29, 2023

#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants