Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some logging of key network events #1601

Open
mrcnski opened this issue Dec 18, 2023 · 2 comments
Open

Add some logging of key network events #1601

mrcnski opened this issue Dec 18, 2023 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Dec 18, 2023

Is your feature request related to a problem? Please describe.

We were recently trying to debug a zombienet test where the issue ultimately was that one of the parachains was not producing blocks. It would have saved a lot of time if zombienet exposed some logs.

Describe the solution you'd like

It would be really nice if we could turn on some logs for zombienet to see key events like:

  1. Relay chain block 20 produced
  2. Relay chain block 20 finalized
  3. Parachain 100 block 5 produced
  4. Session 2 has started
  5. etc.

It would be immediately clear if something wasn't working, and would also help us visualize the tests better and potentially write better assertions.

This could e.g. be enabled with a CLI flag or an env var.

Discoverability: On test failures, zombienet could suggest using the new option to help debugging.

Describe alternatives you've considered

If there exists some way to do this already, it should be better documented because I don't know about it!

Additional context

No response

@pepoviola
Copy link
Collaborator

Hi @mrcnski, thanks for your feedback! I think is a good idea but I just want to ask you for getting a better picture since I'm planning to add some kind of repl into the spawning phase in the new version.
From the point of view of the test-runner (testing phase) you can assert on the block production of the relay/para and you will easily see if there are some issue in the block production.

But having a debug logging in the test-runner that just emit some key events of the network could be handy.

Thx!

@pepoviola pepoviola added enhancement New feature or request question Further information is requested labels Dec 24, 2023
@mrcnski
Copy link
Contributor Author

mrcnski commented Dec 26, 2023

From the point of view of the test-runner (testing phase) you can assert on the block production of the relay/para and you will easily see if there are some issue in the block production.

That's true. The idea is just to get a better picture of what's going on in the network. You could add some tests manually, but it would be hard to answer questions like "how do blocks of para 100 compare with blocks of para 101?" (for example).

I guess polkadot-js already has something kind of like this, which I didn't realize. So maybe that's enough? It would just be a bit more convenient to have the information in one place, in the CLI, when running tests.

But having a debug logging in the test-runner that just emit some key events of the network could be handy.

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants