Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocols fail to consolidate using ExCoveralls #314

Open
netsudo opened this issue Jul 14, 2023 · 2 comments
Open

Protocols fail to consolidate using ExCoveralls #314

netsudo opened this issue Jul 14, 2023 · 2 comments

Comments

@netsudo
Copy link

netsudo commented Jul 14, 2023

Encountering a strange issue, I've implemented some custom protocols recently and tests were passing fine locally using mix test.

The test that's failing inexplicably essentially grabs the metadata types my protocol is implemented for:
{_, impl_for} = MyProtocol.__protocol__(:impls).

This returns a list of metadata types just fine, but when I run mix test --cover, suddenly the test fails and I get:
** (MatchError) no match of right hand side value: :not_consolidated

I've tried consolidating the protocol manually in my test and I get {:error, :no_beam_info}

I'm encountering this discrepancy both locally and in our GH actions. Nothing seems to be of interest in our fairly minimal coveralls config, and our test config is setup to consolidate protocols as well.

Has anybody encountered this? I don't see any issues related to it and I've looked at everything on Google for protocol consolidation in regards to tests and excoveralls.

@jpbecotte
Copy link

Anyone got any idea about this? It's been a year!

@jpbecotte
Copy link

Should be fixed once phoenixframework/phoenix#5831 is delivered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants