Auto-Merged PR even though PR was not reviewed and checks did not pass

[menny]

This is the PR: AnySoftKeyboard/AnySoftKeyboard#2114

I have branch protection enabled:

I'm using github-actions to run PR checks/verifications.
I'm using a personal token (since I need the PR merge to trigger the push-to-master checks).

[karfau]

I think there might be some missing information:

• the checks you are showing are showing the status of the merge commit on the master branch (sha 84a...) and all the checks are green by now.
• the checks for the last commit that has been force pushed to the branch (sha 834...) are also all green including the required master-green-requirement:

If you still believe this is an issue and not just misreading all the different informations, you will need to provide more details or another example.

PS: It is really hard to find the right action run related to a commit, sometimes from the github UI it looks like they are triggered from a master commit but they are actually not.

[menny]

What other information? I provided a screenshot of the auto-merge which was done, and in the same screenshot you can see that not all checks were done, specifically the master-green-requirement

[menny]

This is the action's run.
https://github.com/AnySoftKeyboard/AnySoftKeyboard/runs/498444642?check_suite_focus=true

[karfau]

Am I right that the github action master-green-requirement is only executed on branches or PRs?
The reason why it is not even listed in your sceenshot although it is required for PR to land, is that your screenshot shows the github actions that are (at the time of your screenshot) being executed against the merge commit (84a...) on the master branch, not on the last commit on the branch (834...). At least that is what it looks like for me.

Another issue might be that if your branch protection is not also forcing Admins to require those checks, and your personal token that you are using is for an admin, it might be able to skip the tests. But There is not enough information in this issue to confirm this.

Last but not least: the checkbox in the screenshot doesn't imply that this check was the one merging the PR, it just means that the action run finished successfully (which it can also do if it decides to do nothing).

[pascalgn]

I think this is not yet fixed, or at least it's not clear what the cause for the problem is. However, it's a long time since there was any activity in this issue, so I will close it for now. If you have any new information or need any help, feel free to reopen this issue!