Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataList - implement full page Basic demo to match HTML #8982

Closed
Tracked by #4776
nicolethoen opened this issue Apr 19, 2023 · 1 comment · Fixed by #9087
Closed
Tracked by #4776

DataList - implement full page Basic demo to match HTML #8982

nicolethoen opened this issue Apr 19, 2023 · 1 comment · Fixed by #9087
Assignees
@thatblindgeye
Labels
DevX enhances the consumer developer experience but does not change the experience for the end-user
Milestone
2023.Q4

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Apr 19, 2023 •
edited
Loading

Add a demo to the DataList React demos tab which matches the Basic demo under the HTML Demos tab.

  • It does not need to implement working pagination or filtering - the toolbar at the top of the DataList is for context, so it does not need to be fully functional
  • The Page layout and scaffolding is extremely similar to that of the Card View React demo (code found here). The primary difference is the presence of Cards in the card view demo and DataList in the DataList demo.
  • The DataList items should match as closely as possible to the corresponding HTML Demo
  • The source branch for the issue work should be patternfly-react's V5 branch, and that is also the branch your code should merge back into.
  • It will likely be necessary to move the DataListDemo.md file into a directory much like the CardView demo is in a Card directory under demos.
@nicolethoen nicolethoen mentioned this issue Apr 19, 2023
Open
4 tasks
@nicolethoen nicolethoen changed the title Basic DataList - implement full page Basic demo to match core Apr 19, 2023
@nicolethoen nicolethoen changed the title DataList - implement full page Basic demo to match core DataList - implement full page Basic demo to match HTML Apr 19, 2023
@nicolethoen nicolethoen added this to the Demo backlog milestone Apr 19, 2023
@Kells512
Copy link
Contributor

Hello, I think I had to comment here about taking on the task

@nicolethoen nicolethoen added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Apr 27, 2023
@Kells512 Kells512 mentioned this issue May 4, 2023
Closed
@Kells512 Kells512 mentioned this issue May 15, 2023
Merged
@tlabaj tlabaj added DevX enhances the consumer developer experience but does not change the experience for the end-user and removed Feature end user feature that requires design to define this, i.e. changes or augments the user experience. labels Jun 14, 2023
@nicolethoen nicolethoen self-assigned this Aug 2, 2023
@nicolethoen nicolethoen modified the milestones: Demo backlog, 2023.Q3 Aug 4, 2023
@nicolethoen nicolethoen linked a pull request Aug 9, 2023 that will close this issue
feat(Datalist): implement full page Basic demo to match HTML #9048 #9087
Merged
@wise-king-sullyman wise-king-sullyman modified the milestones: 2023.Q3, 2023.Q4 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
DevX enhances the consumer developer experience but does not change the experience for the end-user
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q4
Development

Successfully merging a pull request may close this issue.

feat(Datalist): implement full page Basic demo to match HTML #9048 Kells512/patternfly-react
5 participants
@wise-king-sullyman @nicolethoen @tlabaj @thatblindgeye @Kells512