Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - ClipboardCopy - ClipboardCopyToggle has a div within a button #9778

Open
wise-king-sullyman opened this issue Oct 27, 2023 · 7 comments

Comments

@wise-king-sullyman
Copy link
Contributor

Followup to patternfly/patternfly#6019

Describe the problem
ClipboardCopy's expansion toggle currently has a div within a button, which is invalid markup.

Expected behavior
The pf-v5-c-clipboard-copy__toggle-icon element should be a span rather than a div.

@thatblindgeye
Copy link
Contributor

Also a followup to comment chain #9574 (comment)

We may not want to spread the className to the div internal to ClipboardCopyToggle as we don't seem to really do that for other _Toggle components, e.g. AccordionToggle.

Copy link

stale bot commented Jan 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 14, 2024
Copy link

stale bot commented Mar 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 16, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Copy link

This issue has been automatically marked as stale because it has not had recent activity.

@github-actions github-actions bot added the stale label Jul 22, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Copy link

github-actions bot commented Oct 5, 2024

This issue has been closed because it has not had activity since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2024
@thatblindgeye thatblindgeye reopened this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs triage
Development

No branches or pull requests

2 participants