Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - MenuItem - does not support download prop/attribute #9890

Closed
rhamilto opened this issue Dec 13, 2023 · 2 comments · Fixed by #9892
Closed

Bug - MenuItem - does not support download prop/attribute #9890

rhamilto opened this issue Dec 13, 2023 · 2 comments · Fixed by #9892
Labels
bug
Milestone
Prioritized Backlog

Comments

@rhamilto
Copy link
Member

rhamilto commented Dec 13, 2023 •
edited
Loading

Describe the problem
MenuItem supports html anchor element attributes rel and target, but not download. This results in the inability to get MenuItem links to engage the browser's download behavior.

How do you reproduce the problem?
See CodeSandbox and note the download attribute is not output to the DOM.

Screenshot 2023-12-13 at 2 47 15 PM
@rhamilto rhamilto added the bug label Dec 13, 2023
@rhamilto
Copy link
Member Author

@nicolethoen, this is needed for OpenShift console.

@rhamilto
Copy link
Member Author

I am going to work on a fix for this.

@tlabaj tlabaj added this to the Prioritized Backlog milestone Dec 13, 2023
@rhamilto rhamilto mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
PatternFly Issues
Archived in project
Milestone
Prioritized Backlog
Development

Successfully merging a pull request may close this issue.

Add download to MenuItem rhamilto/patternfly-react
2 participants
@rhamilto @tlabaj