From 34c49e621b1dbde33b06caa0203483c2d70dbd4e Mon Sep 17 00:00:00 2001 From: Paul M Cohen Date: Sat, 14 Sep 2024 16:35:48 -0700 Subject: [PATCH] Lengthen timeout so test passes on slower servers. This fixes issue #12140 --- .../Microsoft/VisualBasic/Devices/NetworkTests.cs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Devices/NetworkTests.cs b/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Devices/NetworkTests.cs index f42ef99d824..e4f66d4de7b 100644 --- a/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Devices/NetworkTests.cs +++ b/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Devices/NetworkTests.cs @@ -12,8 +12,13 @@ public void IsAvailable() Assert.Equal(System.Net.NetworkInformation.NetworkInterface.GetIsNetworkAvailable(), network.IsAvailable); } + /// + /// The ping API exposed by is in units of Milliseconds, Pinging + /// local server takes approximately 1 Millisecond so there is no reliable way + /// to test a short timeout that for a timeout exception. + /// [Fact] - public void Ping_ShortTimeout_Success() + public void Ping_LongTimeout_Success() { Network network = new(); network.Ping("127.0.0.1", 1).Should().BeTrue(); @@ -33,14 +38,11 @@ public void Ping_Throw() Assert.Throws(() => network.Ping((string)null)); } - [ActiveIssue("https://github.com/dotnet/winforms/issues/12140")] [Fact] - [SkipOnArchitecture(TestArchitectures.Any, - "Flaky tests, see: https://github.com/dotnet/winforms/issues/12140")] public void PingUri_ShortTimeout_Success() { Network network = new(); - network.Ping(new Uri("http://127.0.0.1"), 1).Should().BeTrue(); + network.Ping(new Uri("http://127.0.0.1"), 100).Should().BeTrue(); } [Fact]