Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent loop setting #21

Open
peteroupc opened this issue Jul 18, 2024 · 2 comments
Open

Persistent loop setting #21

peteroupc opened this issue Jul 18, 2024 · 2 comments

Comments

@peteroupc
Copy link

peteroupc commented Jul 18, 2024

The Drumstick player should have a loop button that behaves similarly to other audio players. When the button is pressed, every MIDI file played from then on will loop until the button is pressed again. Thus, for example, the loop option persists across MIDI files and even when the Drumstick player is closed and opened again.

  • For this loop button, by default, the loop start and loop end should be the beginning and end of the MIDI file. The loop start and end can instead be those given in the MIDI file if the MIDI file follows certain loop-point conventions such as the so-called RPG Maker convention (see also Implement loop points within MIDI files nmlgc/ssg#25).

Currently, in order to loop the playback of a MIDI file, the Loop option must first be chosen from the File menu. The MIDI file will then loop until the MIDI file is closed or another MIDI file is opened. In order to loop the new MIDI file, the Loop option must be selected again, which I find cumbersome if I want every MIDI file I play to loop.

@pedrolcl
Copy link
Owner

Currently, in order to loop the playback of a MIDI file, the Loop option must first be chosen from the File menu.

You can create a loop button in the toolbar, using the "Tool Bar Editor" (Settings -> Customize Toolbar...)
https://dmidiplayer.sourceforge.io/manual.shtml#toolbar-customization

image

There is another related function: File->Playlist repeat, which has 3 options: Nothing, Current Song, and Whole Playlist.

@peteroupc
Copy link
Author

peteroupc commented Jul 18, 2024

Indeed, there was a button titled Loop in the bottom of the window all along; the width the window takes on by default apparently hid it out of sight.

And indeed, Playlist Repeat > Current Song already fulfills the persistent loop setting I was seeking.

Thus, most of this issue is resolved for me.

Now all that remains is the following:

  • The Playlist Repeat setting doesn't persist across runs of the program, it seems.
  • The player should support the special looping behavior of MIDI files that follow certain loop-point conventions such as the so-called RPG Maker convention (control change message 111 marks where to restart the MIDI file when playback reaches the end of the file). But that is probably out of scope for this issue unless you want to implement those conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants