Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options must be specified before verify subcommand #83

Closed
merwok opened this issue Dec 11, 2018 · 7 comments
Closed

Options must be specified before verify subcommand #83

merwok opened this issue Dec 11, 2018 · 7 comments

Comments

@merwok
Copy link

merwok commented Dec 11, 2018

Hello and thanks for publishing this tool!

My projects tend to have four or five requirements files using the .in/.txt convention in a deps directory. pip-tools lacks a mode to convert many files at once (jazzband/pip-tools#532) and has no config file for options (jazzband/pip-tools#604), so I have been using a wrapper script that is not very satisfying.

pip-compile-multi -d deps --no-upgrades works well to convert my files.
(The fact that upgrade is true by default is another issue! Most of the time I added an item to the .in file and want to generate the lock file without changing what’s already there.)

pip-compile-multi verify -d deps does not work!

Usage: pip-compile-multi verify [OPTIONS]
Try "pip-compile-multi verify --help" for help.

Error: no such option: -d

pip-compile-multi -d deps verify works.

The documentation could include a working example of verify + options; it could also say that the options must come before the subcommand; the error message could be better.

@peterdemin
Copy link
Owner

Hi Éric, thanks for the feedback. I'm glad that pip-compile-multi provides a value to your projects.
I totally agree, verify should accept options as Usage states.
I'm short on time these days, but I'd be happy to merge a fix from a pull request if you don't mind opening one.

@merwok
Copy link
Author

merwok commented Dec 11, 2018

I haven’t used click but could look into this in a couple weeks!

@peterdemin
Copy link
Owner

Hi @merwok, don't mean to push, but maybe you just forgot ;-)

@merwok
Copy link
Author

merwok commented Feb 20, 2019

I have been busy and don’t think I will be able to work on this in the short term.

@peterdemin
Copy link
Owner

Fixed in 1.5.3

@merwok
Copy link
Author

merwok commented Sep 17, 2019

Great to hear!

Sorry you had a packaging issue. I think the proper fix would be to amend setup.py to have packages=["pipcompilemulti", "pipcompilemulti.features"] rather than collecting the modules with MANIFEST.in and relying on luck to make the build/install commands process these files.

@peterdemin
Copy link
Owner

Thanks for the suggestion, I simplified MANIFEST and fixed setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants