Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todos #13

Closed
phax opened this issue Feb 11, 2022 · 2 comments
Closed

Todos #13

phax opened this issue Feb 11, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@phax
Copy link
Owner

phax commented Feb 11, 2022

  • Avoid empty cbc:StreetName

  • Avoid empty cbc:CityName

  • Avoid empty cbc:PostalZone

  • Avoid empty InvoiceLine/Item/Description

  • Avoid constructs like this (eg. empty SalesOrderID):

  <cac:OrderReference>
    <cbc:ID></cbc:ID>
  </cac:OrderReference>
  • Consider removing 0 values:
      <cbc:AllowanceTotalAmount currencyID="EUR">0.00</cbc:AllowanceTotalAmount>
      <cbc:ChargeTotalAmount currencyID="EUR">0.00</cbc:ChargeTotalAmount>
      <cbc:PrepaidAmount currencyID="EUR">0.00</cbc:PrepaidAmount>
  • In AllowanceCharge to be ignored:
<cbc:BaseAmount currencyID="EUR">0.00</cbc:BaseAmount>
  • Support for multiple SellerTradeParty/ID elements

  • Try to avoid unnecessary trailing zeros in decimal numbers

  • The SubjectCode from IncludedNote needs to be copied

<ram:IncludedNote>
  <ram:Content>Die Lieferung erfolgt aufgrund der AGB […] erhältlich unter […]. Auf Wunsch senden wir sie auch zu.</ram:Content>
  <ram:SubjectCode>ADU</ram:SubjectCode>
</ram:IncludedNote>
@phax phax added the enhancement New feature or request label Feb 11, 2022
@phax phax self-assigned this Feb 11, 2022
@phax
Copy link
Owner Author

phax commented Feb 11, 2022

Everything done so far, except:

  • The "Amount" values with 0 are okay. They are only emitted if Allowances and/or Charges are in the invoice.
  • The allowance charge Base Amount is okay as it is

The only things left are:

  • SellerTradeParty/ID

@phax
Copy link
Owner Author

phax commented Feb 12, 2022

Part of 1.4.6 release

@phax phax closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant