-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://www.npmjs.com/package/sha3 now points to the /twuni/sha3.js
repo
#56
Comments
It's a legitimate commit + change, but the intention wasn't to make a hard switch. It's something I needed to do in order to explore CircleCI for this project (which requires administrative permissions I do not have in this org). This is still the repo for active development. Thanks for catching this -- I'll push a patch update to fix. |
@davidmurdoch Fixed in #57. |
I feel like this warrants further context. Any change that unintentionally makes it into production deserves a retrospective. Q. How did these changes make it into the v2.0.3 release? Q. Why was the repo URL changed in the first place? Q. Why are org-level administrative permissions necessary? Q. Why are CircleCI orbs necessary? Q. Why migrate to CircleCI at all? TL;DR. I published the v2.0.3 release from a local build that was tracking against |
Thanks for that retrospective, @canterberry! off topic, but it might be beneficial if you tag the 1.x branch on npm. |
TIL how to tag things on npm. For convenience and to better illustrate the difference between 1.x and 2.x, I've added the |
@canterberry if I could give you an award for Best FOSS Maintainer I would! Thank you! |
Looks it it happened in this commit: 6fe5d15#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L17
Was this on purpose?
The text was updated successfully, but these errors were encountered: