Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access-Control-Allow-Origin in AssetController #676

Closed
NiklasBr opened this issue Sep 2, 2024 · 3 comments · Fixed by #689
Closed

Access-Control-Allow-Origin in AssetController #676

NiklasBr opened this issue Sep 2, 2024 · 3 comments · Fixed by #689
Assignees
Milestone

Comments

@NiklasBr
Copy link
Contributor

NiklasBr commented Sep 2, 2024

'Content-Type' => $thumbnail->getMimeType(),
'Access-Control-Allow-Origin', '*',

Is the above , '*' intentional? Shouldn't it be => '*'?

@NiklasBr
Copy link
Contributor Author

Have you been able to research if this code is as intended @fashxp?

@kingjia90
Copy link
Contributor

kingjia90 commented Sep 11, 2024

By looking at
4feb431#diff-8a94426359af1cadbcb7fdeb7af5731ce2ac295a758ed07a38d36db9d5d85ff9R1261-R1262, it doesn't look intended (also incorrect line break) and should be considered as a typo instead, could you please provide a PR for it so it would be credited to you?(nevermind i was quicker 😄 )

@kingjia90
Copy link
Contributor

Fixed by #689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants