Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Refine phpoffice/phpspreadsheet requirement #17092

Closed
3 tasks done
kingjia90 opened this issue May 27, 2024 · 0 comments · Fixed by pimcore/admin-ui-classic-bundle#539, pimcore/data-importer#410 or #17091
Closed
3 tasks done

[Improvement]: Refine phpoffice/phpspreadsheet requirement #17092

kingjia90 opened this issue May 27, 2024 · 0 comments · Fixed by pimcore/admin-ui-classic-bundle#539, pimcore/data-importer#410 or #17091
Assignees
@kingjia90
Labels
Improvement
Milestone
11.3.0

Comments

@kingjia90
Copy link
Contributor

kingjia90 commented May 27, 2024 •
edited
Loading

Improvement description

Related https://github.com/orgs/pimcore/discussions/17087

While thinking of extending the supporting to the v2, found out this package is not used in the pimcore/pimcore and should be moved in where it is actually required

could it be then remove it from the composer of pimcore/pimcore v12 or could it be already in a minor release? Might be a little similar to the situation of #16966

Confirmed by Bernie that can be removed in a minor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingjia90 kingjia90

Labels
Improvement
Projects
None yet
Milestone
11.3.0
1 participant
@kingjia90