varchar value should use quotation marks

[alex-quan-001]

Error Report

Please answer the following questions before submitting your issue. Thanks!

1. What is the URL/path of the document related to this issue?

https://docs.pingcap.com/tidb/stable/garbage-collection-configuration
tikv_gc_enable
Enables or disables GC
Default: true

2. How would you like to improve it?
   tikv_gc_enable
   Enables or disables GC
   Default:" true"

all variable value's type is varchar, so it should be include in quotes.

desc mysql.tidb;
+----------------+---------------+------+------+---------+-------+
| Field | Type | Null | Key | Default | Extra |
+----------------+---------------+------+------+---------+-------+
| VARIABLE_NAME | varchar(64) | NO | PRI | NULL | |
| VARIABLE_VALUE | varchar(1024) | YES | | NULL | |
| COMMENT | varchar(1024) | YES | | NULL | |
+----------------+---------------+------+------+---------+-------+

[TomShawn]

@alex-quan-001 Do we also need to quote "true" in commands like set config tikv gc.enable-compaction-filter = "true";?

[alex-quan-001]

I don`t know this usage.
Not even sure if it's used that way. I don't know how it works even when I try it and it doesn't report an error when I set it up incorrectly.
But at least what I see should fit the design, and preferably there should be no implicit conversion of the parameters of the setup class and a strong checksum.

[TomShawn]

@MyonKeminta Could you please take a look? Thanks!

[morgo]

This is fixed in #4552 where the recommended GC configuration moves to sysvars.

The mysql.tidb interface should be deprecated because it does not permit any validation on the values that are being set. See: pingcap/tidb#20655

With sysvars, there is both validation and type normalization (oN, 1, on, ON --> ON).

[TomShawn]

This is fixed in #4552 where the recommended GC configuration moves to sysvars.

The mysql.tidb interface should be deprecated because it does not permit any validation on the values that are being set. See: pingcap/tidb#20655

With sysvars, there is both validation and type normalization (oN, 1, on, ON --> ON).

@alex-quan-001 Does this answer address your question?