From 6aa06958276d42c9a2732a827d7f0db320bf2689 Mon Sep 17 00:00:00 2001
From: shuijing198799 <yinliang@pingcap.com>
Date: Thu, 19 Mar 2020 11:41:36 +0800
Subject: [PATCH] address comment

---
 charts/tidb-lightning/templates/job.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/charts/tidb-lightning/templates/job.yaml b/charts/tidb-lightning/templates/job.yaml
index cc80ce2f4a..90faf4c859 100644
--- a/charts/tidb-lightning/templates/job.yaml
+++ b/charts/tidb-lightning/templates/job.yaml
@@ -43,8 +43,10 @@ spec:
         - |
 {{ tuple "scripts/_start_data_retriever.sh.tpl" . | include "helm-toolkit.utils.template" | indent 10 }}
         volumeMounts:
+        {{- if or .Values.dataSource.remote.rcloneConfig .Values.dataSource.remote.secretName}}
         - name: credentials
           mountPath: /etc/rclone
+        {{ end -}}
         - name: data
           mountPath: /data
       {{ if and (ne .Values.timezone "UTC") (ne .Values.timezone "") }}
@@ -125,12 +127,10 @@ spec:
           items:
           - key: config-file
             path: rclone.conf
-      {{ else }}
+      {{- else if .Values.dataSource.remote.secretName }}
       - name: credentials
         secret:
-          {{- if .Values.dataSource.remote.secretName}}
           secretName: {{ .Values.dataSource.remote.secretName }}
-          {{- end }}
       {{- end }}
       - name: data
         persistentVolumeClaim: