Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support logging rejected connection attempts in audit log #14563

Closed
kolbe opened this issue Jan 22, 2020 · 1 comment · Fixed by #14594
Closed

Support logging rejected connection attempts in audit log #14563

kolbe opened this issue Jan 22, 2020 · 1 comment · Fixed by #14594
Assignees
@lysu
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@kolbe
Copy link
Contributor

kolbe commented Jan 22, 2020

Feature Request

The audit log should include failed/reject connection attempts in addition to successful connection attempts.

I think this is most easily handled by adding another ConnectionEvent const in plugin/audit.go.

One issue with that is that it would be nice to be able to include the reason for rejection/failure in the audit log message, but OnConnectionEvent() doesn't accept any arguments to represent that very well.
@kolbe kolbe added the type/enhancement The issue or PR belongs to an enhancement. label Jan 22, 2020
@lysu lysu self-assigned this Jan 22, 2020
@kolbe
Copy link
Contributor Author

kolbe commented Jan 23, 2020 •
edited
Loading

This is a simple approach to solve this, by creating a new type of audit entry: release-3.1...kolbe:kolbe-audit-rejected

@lysu lysu mentioned this issue Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lysu lysu

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugin: support logging rejected connection attempts in audit log
2 participants
@lysu @kolbe