We can't execute update ... where colName ... when the column is WriteOnly state

[zimulala]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?

create table t (a int, b int)
insert into t values(1,1);

Do the following:

time	connection1	connection2
t1	drop column b
t2	column state (write only)	update t set a=5 where b=1;

2. What did you expect to see?

Retrun an error like [planner:1054]Unknown column 'b' in 'field list'.

3. What did you see instead?

Statement executed successfully

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

Release Version: v4.0.0-beta.2-46-gfd0235d03
Git Commit Hash: fd0235d
Git Branch: master

[qw4990]

@zimulala Since #15539 has been merged, is this issue fixed and can we close it?

[zimulala]

@qw4990
No. #15539 fix the issue of #15386.

[killua525]

expect execute successful
#15539 why return error？

[zimulala]

@jzdxeb
Do you mean why update t set a =2 ,b=2 return an error when b's state is write-only?
Because clients only see the column when the column's state is public. So we can't update the value of b explicitly.

[killua525]

thx a lot

[killua525]

in branch release 3.0

mysql> update t set b=5 where a=1;
ERROR 1054 (42S22): Unknown column 'b' in 'field list'
mysql> update t set a=5 where b=1;
Query OK, 0 rows affected (0.00 sec)
Rows matched: 1  Changed: 0  Warnings: 0

is expect ?

[zimulala]

Column B in this scene is not public, is it? If column b is not public, it is the problem described by this issue. update t set a=5 where b=1; also needs to return an error.

[killua525]

branch master
commit f139821

update t set a=5 where b=1 return successfully

timeline

time	connection1	connection2
t1	drop b
t2		update t set a=5 where b=1
t3		update t set b=5 where a=1
t4	drop b done

diff --git a/Makefile b/Makefile
index 793d44b7c..3af1e8137 100644
--- a/Makefile
+++ b/Makefile
@@ -214,9 +214,9 @@ endif

 server:
 ifeq ($(TARGET), "")
-       CGO_ENABLED=1 $(GOBUILD) $(RACE_FLAG) -ldflags '$(LDFLAGS) $(CHECK_FLAG)' -o bin/tidb-server tidb-server/main.go
+       CGO_ENABLED=0 $(GOBUILD) $(RACE_FLAG) -ldflags '$(LDFLAGS) $(CHECK_FLAG)' -o bin/tidb-server tidb-server/main.go
 else
-       CGO_ENABLED=1 $(GOBUILD) $(RACE_FLAG) -ldflags '$(LDFLAGS) $(CHECK_FLAG)' -o '$(TARGET)' tidb-server/main.go
+       CGO_ENABLED=0 $(GOBUILD) $(RACE_FLAG) -ldflags '$(LDFLAGS) $(CHECK_FLAG)' -o '$(TARGET)' tidb-server/main.go
 endif

 server_check:
diff --git a/ddl/column.go b/ddl/column.go
index a38c3afab..5e0cf9214 100644
--- a/ddl/column.go
+++ b/ddl/column.go
@@ -515,6 +515,7 @@ func onDropColumn(t *meta.Meta, job *model.Job) (ver int64, _ error) {
                }
                ver, err = updateVersionAndTableInfoWithCheck(t, job, tblInfo, originalState != colInfo.State)
        case model.StateWriteOnly:
+               time.Sleep(time.Second * 20)
                // write only -> delete only
                job.SchemaState = model.StateDeleteOnly
                colInfo.State = model.StateDeleteOnly

[xiongjiwei]

/assign

[ti-srebot]

Please edit this comment or add a new comment to complete the following information

Not a bug

1. Remove the 'type/bug' label
2. Add notes to indicate why it is not a bug

Duplicate bug

1. Add the 'type/duplicate' label
2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions