Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test TestAutoUpdate failed in 4.0 branch when new collation is enabled. #19713

Open
bb7133 opened this issue Sep 2, 2020 · 2 comments
Open
Assignees
Labels
severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@bb7133
Copy link
Member

bb7133 commented Sep 2, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Enable the new collation by changing the code in

func init() {
        newCollationEnabled = 1  // always enable the new collation

	newCollatorMap = make(map[string]Collator)
        ...

And then run the test TestAutoUpdate:

bash$ cd $TIDB_SRC/statistics/handle
bash$ go test -check.f TestAutoUpdate

2. What did you expect to see? (Required)

The test case ran successfully.

3. What did you see instead (Required)

FAIL: update_test.go:371: testStatsSuite.TestAutoUpdate

update_test.go:464:
    c.Assert(hg.NDV, Equals, int64(3))
... obtained int64 = 1
... expected int64 = 3

4. What is your TiDB version? (Required)

The commit hash is 3b2c7e763a3a918c5247fb2ac7cf551cb0460679 in release-4.0.

This issue is not reproduced in master branch.

@bb7133 bb7133 added the type/bug The issue is confirmed as a bug. label Sep 2, 2020
@bb7133
Copy link
Member Author

bb7133 commented Sep 2, 2020

@winoros PTAL

@yudongusa
Copy link

@bb7133 @winoros should we close this issue if it no more exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

5 participants