Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: some logs and assumptions are inaccurate when the async commit protocol is used #23542

Open
cfzjywxk opened this issue Mar 25, 2021 · 3 comments · May be fixed by #24140
Open

txn: some logs and assumptions are inaccurate when the async commit protocol is used #23542

cfzjywxk opened this issue Mar 25, 2021 · 3 comments · May be fixed by #24140
Labels
severity/minor sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Mar 25, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

There are some logs and assumptions which are inaccurate or wrong when the async commit protocol is used, they are:

  1. https://github.com/pingcap/tidb/blob/master/store/tikv/commit.go#L146 when the async commit protocol is used, the first commit batch which is committed successful may not contain the primary lock, the committed field set logic for async commit transactions needs fixing.
  2. The related log https://github.com/pingcap/tidb/blob/master/store/tikv/commit.go#L129 is also needed to update.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master
release-5.0

@cfzjywxk cfzjywxk added type/bug The issue is confirmed as a bug. sig/transaction SIG:Transaction severity/minor labels Mar 25, 2021
@zhaoxugang
Copy link
Contributor

/pick-up

@zhaoxugang
Copy link
Contributor

I'm instrest about transaction,can i try to resolve this issue?@cfzjywxk

@cfzjywxk
Copy link
Contributor Author

I'm instrest about transaction,can i try to resolve this issue?@cfzjywxk

Sure, you could check about https://github.com/tikv/sig-transaction for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
2 participants