Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for executor/write_concurrent_test.go #26160

Closed
Tracked by #26854
tisonkun opened this issue Jul 12, 2021 · 1 comment · Fixed by #26712
Closed
Tracked by #26854

migrate test-infra to testify for executor/write_concurrent_test.go #26160

tisonkun opened this issue Jul 12, 2021 · 1 comment · Fixed by #26712
Assignees
@tisonkun

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Jul 12, 2021 •
edited
Loading

This file is the only case where testkit.CTestKit in used. We may write some particular fixture for the case and just remove CTestKit.
@tisonkun tisonkun mentioned this issue Jul 12, 2021
Closed
53 tasks
@tisonkun
Copy link
Contributor Author

.. or you may figure out the difference between CTestKit and TestKit to see if we can join these two abstractions and use executor/write_concurrent_test.go as its first client.

Then we also resolve #26108 .

@tisonkun tisonkun self-assigned this Jul 28, 2021
This was referenced Jul 28, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tisonkun tisonkun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: migrate TestBatchInsertWithOnDuplicate to testify tisonkun/tidb
1 participant
@tisonkun