Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for util/ranger pkg #26411

Closed
Tracked by #33453
tisonkun opened this issue Jul 21, 2021 · 4 comments · Fixed by #26988
Closed
Tracked by #33453

migrate test-infra to testify for util/ranger pkg #26411

tisonkun opened this issue Jul 21, 2021 · 4 comments · Fixed by #26988
Assignees
@feitian124
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Jul 21, 2021
Closed
53 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 21, 2021
@feitian124
Copy link
Contributor

/assign

@feitian124
Copy link
Contributor

i am migrating util/ranger which depends on util/testkit and util/testutil
i see you re-implemented a TestKit and let it gradually replace utils/testkit in #26108 , how about util/testutil?
and does not find a tracker for util/testutil in #26022

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 5, 2021

util/testutil is going to be dropped. You may move functions to testkit/ or if the function used in few places which means uncommon, inline it.

@feitian124
Copy link
Contributor

found 518 usage of util/testutil in whole repo.
i am afraid we have to use similiar manner like util/testkit: re-implemented util/testutil in testkit/ and let it gradually replace the old one

@feitian124 feitian124 mentioned this issue Aug 7, 2021
Merged
@tisonkun tisonkun mentioned this issue Mar 25, 2022
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feitian124 feitian124

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util/ranger: migrate test-infra to testify feitian124/tidb
2 participants
@feitian124 @tisonkun