Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for server #26863

Closed
10 tasks done
Tracked by #26022
tisonkun opened this issue Aug 3, 2021 · 11 comments
Closed
10 tasks done
Tracked by #26022

migrate test-infra to testify for server #26863

tisonkun opened this issue Aug 3, 2021 · 11 comments
Assignees
@yedamao
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2021 •
edited
Loading

You may try to analyze first and spawn more subtasks on demand (no strict) instead of one big PR handle the whole package which is hard to review.
@tisonkun tisonkun mentioned this issue Aug 3, 2021
Closed
53 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 3, 2021
@yedamao
Copy link
Contributor

yedamao commented Aug 6, 2021

/assign

This was referenced Aug 6, 2021
Closed
Closed
@yedamao
Copy link
Contributor

yedamao commented Aug 9, 2021 •
edited by tisonkun
Loading

Please add #27041 as subtask of this issue.

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 9, 2021

Please add #27041 as subtask of this issue.

done.

This was referenced Aug 18, 2021
Closed
Closed
@yedamao
Copy link
Contributor

yedamao commented Aug 18, 2021

Please add #27342 and #27343 as subtask of this issue.

@tisonkun
Copy link
Contributor Author

Please add #27342 and #27343 as subtask of this issue.

done

This was referenced Aug 26, 2021
Closed
Closed
This was referenced Sep 3, 2021
Closed
Closed
Closed
Closed
Closed
@yedamao
Copy link
Contributor

yedamao commented Sep 3, 2021

@tisonkun Please add #27804 #27805 #27806 #27807 #27808 as subtask of this issue.

@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 3, 2021

@yedamao updated. Thanks a lot for driving this issue!

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 8, 2021

@yedamao do you have a plan to continue the rest tasks? I suggest you to resolve them one suite and the other - each file seems too large to be finished at once.

Also you can trying to call for other contributors by sending a request on Twitter or WeChat moments or blogs. If so, feel free to add it to tisonkun/weekly#11.

@yedamao
Copy link
Contributor

yedamao commented Oct 11, 2021

@tisonkun Thanks for the suggestion, I will continue work on this.

@tisonkun
Copy link
Contributor Author

tisonkun commented Nov 4, 2021 •
edited
Loading

@yedamao I finished #27804 recently and there are #27805 & #27806 left.

I think the order is to solve #27806 first and then #27805 .

@tisonkun
Copy link
Contributor Author

Closed as all subtasks are done. Thank you so much for driving this issue @yedamao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yedamao yedamao

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yedamao @tisonkun