Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race in br/pkg/lightning/mydump.setDatumByInt() #27473

Closed
Tracked by #25899
zhouqiang-cl opened this issue Aug 23, 2021 · 1 comment · Fixed by #27482
Closed
Tracked by #25899

data race in br/pkg/lightning/mydump.setDatumByInt() #27473

zhouqiang-cl opened this issue Aug 23, 2021 · 1 comment · Fixed by #27482
Labels
component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@zhouqiang-cl
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

[2021-08-23T01:47:18.489Z] WARNING: DATA RACE
[2021-08-23T01:47:18.489Z] Read at 0x000005e1e900 by goroutine 63:
[2021-08-23T01:47:18.489Z]   time.Now()
[2021-08-23T01:47:18.489Z]       /usr/local/go/src/time/time.go:1073 +0xf6
[2021-08-23T01:47:18.489Z]   time.sendTime()
[2021-08-23T01:47:18.489Z]       /usr/local/go/src/time/sleep.go:149 +0x49
[2021-08-23T01:47:18.490Z] 
[2021-08-23T01:47:18.490Z] Previous write at 0x000005e1e900 by goroutine 70:
[2021-08-23T01:47:18.490Z]   ??()
[2021-08-23T01:47:18.490Z]       -:0 +0xffffffffffffffff
[2021-08-23T01:47:18.490Z]   fmt.(*pp).fmtInteger()
[2021-08-23T01:47:18.490Z]       /usr/local/go/src/fmt/print.go:379 +0x20d
[2021-08-23T01:47:18.490Z]   fmt.(*pp).printArg()
[2021-08-23T01:47:18.490Z]       /usr/local/go/src/fmt/print.go:680 +0x96f
[2021-08-23T01:47:18.490Z]   fmt.(*pp).doPrintf()
[2021-08-23T01:47:18.490Z]       /usr/local/go/src/fmt/print.go:1122 +0x9f7
[2021-08-23T01:47:18.490Z]   fmt.Sprintf()
[2021-08-23T01:47:18.490Z]       /usr/local/go/src/fmt/print.go:219 +0x73
[2021-08-23T01:47:18.490Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.setDatumByInt()
[2021-08-23T01:47:18.490Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/br/pkg/lightning/mydump/parquet_parser.go:489 +0x1cd
[2021-08-23T01:47:18.490Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.setDatumValue()
[2021-08-23T01:47:18.490Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/br/pkg/lightning/mydump/parquet_parser.go:411 +0x1da
[2021-08-23T01:47:18.490Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.(*ParquetParser).ReadRow()
[2021-08-23T01:47:18.490Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/br/pkg/lightning/mydump/parquet_parser.go:380 +0x51d
[2021-08-23T01:47:18.490Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.testParquetParserSuite.TestParquetVariousTypes()
[2021-08-23T01:47:18.490Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/br/pkg/lightning/mydump/parquet_parser_test.go:194 +0x2064
[2021-08-23T01:47:18.491Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.(*testParquetParserSuite).TestParquetVariousTypes()
[2021-08-23T01:47:18.491Z]       <autogenerated>:1 +0x49
[2021-08-23T01:47:18.491Z]   runtime.call16()
[2021-08-23T01:47:18.491Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-08-23T01:47:18.491Z]   reflect.Value.Call()
[2021-08-23T01:47:18.491Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-08-23T01:47:18.491Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-08-23T01:47:18.491Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-08-23T01:47:18.491Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-08-23T01:47:18.491Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-08-23T01:47:18.491Z] 
[2021-08-23T01:47:18.491Z] Goroutine 63 (running) created at:
[2021-08-23T01:47:18.491Z]   github.com/xitongsys/parquet-go/reader.(*ParquetReader).read()
[2021-08-23T01:47:18.491Z]       /nfs/cache/mod/github.com/xitongsys/parquet-go@v1.5.5-0.20201110004701-b09c49d6d457/reader/reader.go:328 +0x88b
[2021-08-23T01:47:18.491Z]   github.com/xitongsys/parquet-go/reader.(*ParquetReader).Read()
[2021-08-23T01:47:18.491Z]       /nfs/cache/mod/github.com/xitongsys/parquet-go@v1.5.5-0.20201110004701-b09c49d6d457/reader/reader.go:196 +0x1fe
[2021-08-23T01:47:18.491Z]   github.com/xitongsys/parquet-go/reader.(*ParquetReader).ReadByNumber()
[2021-08-23T01:47:18.491Z]       /nfs/cache/mod/github.com/xitongsys/parquet-go@v1.5.5-0.20201110004701-b09c49d6d457/reader/reader.go:212 +0x209
[2021-08-23T01:47:18.491Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.(*ParquetParser).ReadRow()
[2021-08-23T01:47:18.491Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/br/pkg/lightning/mydump/parquet_parser.go:359 +0x8e5
[2021-08-23T01:47:18.491Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.testParquetParserSuite.TestParquetParser()
[2021-08-23T01:47:18.491Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/br/pkg/lightning/mydump/parquet_parser_test.go:65 +0xbb3
[2021-08-23T01:47:18.491Z]   github.com/pingcap/tidb/br/pkg/lightning/mydump.(*testParquetParserSuite).TestParquetParser()
[2021-08-23T01:47:18.492Z]       <autogenerated>:1 +0x49
[2021-08-23T01:47:18.492Z]   runtime.call16()
[2021-08-23T01:47:18.492Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-08-23T01:47:18.492Z]   reflect.Value.Call()
[2021-08-23T01:47:18.492Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-08-23T01:47:18.492Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-08-23T01:47:18.492Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-08-23T01:47:18.492Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-08-23T01:47:18.492Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-08-23T01:47:18.492Z] ==================

1. Minimal reproduce step (Required)

in ci https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb-unit-test-nightly/runs/9385/nodes/117/steps/465/log/?start=0

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@zhouqiang-cl zhouqiang-cl added the type/bug The issue is confirmed as a bug. label Aug 23, 2021
@aytrack aytrack added component/lightning This issue is related to Lightning of TiDB. severity/major labels Aug 23, 2021
@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants