Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race in executor_test.(*mockSessionManager2).Kill() #27822

Closed
Tracked by #25899
zhouqiang-cl opened this issue Sep 6, 2021 · 1 comment · Fixed by #27864
Closed
Tracked by #25899

data race in executor_test.(*mockSessionManager2).Kill() #27822

zhouqiang-cl opened this issue Sep 6, 2021 · 1 comment · Fixed by #27864
Assignees
Labels
component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@zhouqiang-cl
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

[2021-09-06T02:30:20.970Z] WARNING: DATA RACE
[2021-09-06T02:30:20.970Z] Write at 0x00c04216beb8 by goroutine 620:
[2021-09-06T02:30:20.970Z]   github.com/pingcap/tidb/executor_test.(*mockSessionManager2).Kill()
[2021-09-06T02:30:20.970Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/prepared_test.go:160 +0x44
[2021-09-06T02:30:20.970Z]   github.com/pingcap/tidb/util/expensivequery.(*Handle).Run()
[2021-09-06T02:30:20.970Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/expensivequery/expensivequery.go:75 +0x2ce
[2021-09-06T02:30:20.970Z] 
[2021-09-06T02:30:20.970Z] Previous read at 0x00c04216beb8 by goroutine 686:
[2021-09-06T02:30:20.970Z]   github.com/pingcap/tidb/executor_test.(*testSuite12).TestPreparedStmtWithHint()
[2021-09-06T02:30:20.970Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/prepared_test.go:196 +0x524
[2021-09-06T02:30:20.970Z]   runtime.call16()
[2021-09-06T02:30:20.970Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-09-06T02:30:20.970Z]   reflect.Value.Call()
[2021-09-06T02:30:20.970Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-09-06T02:30:20.970Z] 
[2021-09-06T02:30:20.970Z] Goroutine 620 (running) created at:
[2021-09-06T02:30:20.970Z]   github.com/pingcap/tidb/executor_test.(*testSuite12).TestPreparedStmtWithHint()
[2021-09-06T02:30:20.970Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/prepared_test.go:193 +0x404
[2021-09-06T02:30:20.970Z]   runtime.call16()
[2021-09-06T02:30:20.970Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-09-06T02:30:20.970Z]   reflect.Value.Call()
[2021-09-06T02:30:20.970Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-09-06T02:30:20.970Z] 
[2021-09-06T02:30:20.970Z] Goroutine 686 (running) created at:
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.(*suiteRunner).run()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:696 +0x144
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.Run()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:150 +0x5a
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.RunAll()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:136 +0x968
[2021-09-06T02:30:20.970Z]   github.com/pingcap/check.TestingT()
[2021-09-06T02:30:20.970Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:99 +0x756
[2021-09-06T02:30:20.970Z]   github.com/pingcap/tidb/executor_test.TestT()
[2021-09-06T02:30:20.970Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/executor_test.go:109 +0x335
[2021-09-06T02:30:20.970Z]   testing.tRunner()
[2021-09-06T02:30:20.970Z]       /usr/local/go/src/testing/testing.go:1193 +0x202
[2021-09-06T02:30:20.970Z] ==================

1. Minimal reproduce step (Required)

in ci https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb-unit-test-nightly/runs/10245/nodes/104/steps/269/log/?start=0

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Please check whether the issue should be labeled with 'affects-x.y' or 'backport-x.y.z',
and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants