Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race in expression/builtin_cast_vec_test.go #29164

Closed
Tracked by #25899
zhouqiang-cl opened this issue Oct 27, 2021 · 2 comments · Fixed by #29276
Closed
Tracked by #25899

data race in expression/builtin_cast_vec_test.go #29164

zhouqiang-cl opened this issue Oct 27, 2021 · 2 comments · Fixed by #29276
Assignees
Labels
component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@zhouqiang-cl
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

[2021-10-27T02:27:43.503Z] WARNING: DATA RACE
[2021-10-27T02:27:43.503Z] Read at 0x00c000320000 by goroutine 94:
[2021-10-27T02:27:43.503Z]   math/rand.(*rngSource).Uint64()
[2021-10-27T02:27:43.503Z]       /usr/local/go/src/math/rand/rng.go:239 +0x3e
[2021-10-27T02:27:43.503Z]   math/rand.(*rngSource).Int63()
[2021-10-27T02:27:43.503Z]       /usr/local/go/src/math/rand/rng.go:234 +0x1d9
[2021-10-27T02:27:43.503Z]   math/rand.(*Rand).Int63()
[2021-10-27T02:27:43.503Z]       /usr/local/go/src/math/rand/rand.go:85 +0xbc
[2021-10-27T02:27:43.503Z]   math/rand.(*Rand).Float64()
[2021-10-27T02:27:43.503Z]       /usr/local/go/src/math/rand/rand.go:196 +0xc2
[2021-10-27T02:27:43.503Z]   github.com/pingcap/tidb/expression.(*decimalJSONGener).gen()
[2021-10-27T02:27:43.503Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:360 +0x45
[2021-10-27T02:27:43.503Z]   github.com/pingcap/tidb/expression.fillColumnWithGener()
[2021-10-27T02:27:43.503Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:1005 +0x158
[2021-10-27T02:27:43.503Z]   github.com/pingcap/tidb/expression.fillColumn()
[2021-10-27T02:27:43.503Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:993 +0x104
[2021-10-27T02:27:43.503Z]   github.com/pingcap/tidb/expression.genVecExprBenchCase()
[2021-10-27T02:27:43.503Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:1082 +0x438
[2021-10-27T02:27:43.503Z]   github.com/pingcap/tidb/expression.testVectorizedEvalOneVec()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:1107 +0x199
[2021-10-27T02:27:43.504Z]   github.com/pingcap/tidb/expression.TestVectorizedBuiltinCastEvalOneVec()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/builtin_cast_vec_test.go:153 +0x54
[2021-10-27T02:27:43.504Z]   testing.tRunner()
[2021-10-27T02:27:43.504Z]       /usr/local/go/src/testing/testing.go:1193 +0x202
[2021-10-27T02:27:43.504Z] 
[2021-10-27T02:27:43.504Z] Previous write at 0x00c000320000 by goroutine 122:
[2021-10-27T02:27:43.504Z]   math/rand.(*rngSource).Uint64()
[2021-10-27T02:27:43.504Z]       /usr/local/go/src/math/rand/rng.go:239 +0x54
[2021-10-27T02:27:43.504Z]   math/rand.(*rngSource).Int63()
[2021-10-27T02:27:43.504Z]       /usr/local/go/src/math/rand/rng.go:234 +0x1d9
[2021-10-27T02:27:43.504Z]   math/rand.(*Rand).Int63()
[2021-10-27T02:27:43.504Z]       /usr/local/go/src/math/rand/rand.go:85 +0xbc
[2021-10-27T02:27:43.504Z]   math/rand.(*Rand).Float64()
[2021-10-27T02:27:43.504Z]       /usr/local/go/src/math/rand/rand.go:196 +0xc2
[2021-10-27T02:27:43.504Z]   github.com/pingcap/tidb/expression.(*decimalJSONGener).gen()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:360 +0x45
[2021-10-27T02:27:43.504Z]   github.com/pingcap/tidb/expression.fillColumnWithGener()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:1005 +0x158
[2021-10-27T02:27:43.504Z]   github.com/pingcap/tidb/expression.fillColumn()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:993 +0x104
[2021-10-27T02:27:43.504Z]   github.com/pingcap/tidb/expression.genVecBuiltinFuncBenchCase()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:1223 +0x417
[2021-10-27T02:27:43.504Z]   github.com/pingcap/tidb/expression.testVectorizedBuiltinFunc()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/bench_test.go:1344 +0x5a4
[2021-10-27T02:27:43.504Z]   github.com/pingcap/tidb/expression.TestVectorizedBuiltinCastFunc()
[2021-10-27T02:27:43.504Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/expression/builtin_cast_vec_test.go:157 +0x54
[2021-10-27T02:27:43.504Z]   testing.tRunner()
[2021-10-27T02:27:43.504Z]       /usr/local/go/src/testing/testing.go:1193 +0x202

1. Minimal reproduce step (Required)

in ci https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb-unit-test-nightly/runs/13151/nodes/114/steps/461/log/?start=0

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

@zhouqiang-cl zhouqiang-cl added the type/bug The issue is confirmed as a bug. label Oct 27, 2021
@zhouqiang-cl zhouqiang-cl changed the title data race in ` data race in expression/builtin_cast_vec_test.go Oct 27, 2021
@tisonkun tisonkun self-assigned this Nov 1, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Nov 1, 2021

Can be resolved by #29276 . Waiting for review =。=

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants