Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support str_to_date function push down #1942

Closed
zanmato1984 opened this issue May 20, 2021 · 8 comments
Closed

Support str_to_date function push down #1942

zanmato1984 opened this issue May 20, 2021 · 8 comments
Assignees
@JaySon-Huang
Labels
component/expression type/new-feature Issue or PR for new feature

Comments

@zanmato1984
Copy link
Contributor

zanmato1984 commented May 20, 2021 •
edited by JaySon-Huang
Loading

Need to take care of the performance issue. Related optimization PR for date_format(#1337) (inverse function for str_to_date).

PR to master (and 5.1.0)
tiflash: #1961
tidb: pingcap/tidb#25095
@zanmato1984 zanmato1984 added component/expression type/new-feature Issue or PR for new feature labels May 20, 2021
@zanmato1984 zanmato1984 assigned JaySon-Huang and unassigned leiysky May 21, 2021
@JaySon-Huang JaySon-Huang mentioned this issue May 21, 2021
Closed
20 tasks
@windtalker
Copy link
Contributor

Currently, only StrToDateDatetime is needed

@zanmato1984
Copy link
Contributor Author

We can implement this usage first if time is a concern. We will conduct customer case trial on Mon/Tue to see if other usages are required.

Of course implementing all usages is better, if time allows.

@JaySon-Huang

@JaySon-Huang
Copy link
Contributor

Get it @windtalker @zanmato1984

This was referenced May 22, 2021
Merged
Merged
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 23, 2021 •
edited
Loading

TiDB branch for supporting push down str_to_date pingcap/tidb#24847
TiFlash PR: #1960

@JaySon-Huang
Copy link
Contributor

A following fix for nullable column #1984

@JaySon-Huang JaySon-Huang mentioned this issue May 24, 2021
Merged
@JaySon-Huang
Copy link
Contributor

I've found a bug for fail to parse "03-01-02 8:11:2.123456" with format "%Y-%m-%d %H:%i:%S.%#". But I think it is OK not to pick to the POC branch.
The bug is fixed in #1961 that will be merged into master

@ti-srebot ti-srebot mentioned this issue Jun 3, 2021
Merged
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 3, 2021 •
edited
Loading

PR to master (and 5.1.0)
tiflash: #1961
tidb: pingcap/tidb#25095

@JaySon-Huang JaySon-Huang mentioned this issue Jun 3, 2021
Merged
@zanmato1984
Copy link
Contributor Author

Related to #1847

@ti-srebot ti-srebot mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaySon-Huang JaySon-Huang

Labels
component/expression type/new-feature Issue or PR for new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zanmato1984 @windtalker @JaySon-Huang @leiysky