Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified sorter manual GC may pause all goroutines and cause gRPC keepalive dog timeout #2202

Closed
overvenus opened this issue Jul 1, 2021 · 2 comments · Fixed by #2214
Closed

Unified sorter manual GC may pause all goroutines and cause gRPC keepalive dog timeout #2202

overvenus opened this issue Jul 1, 2021 · 2 comments · Fixed by #2214
Assignees
@overvenus
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 area/ticdc Issues or PRs related to TiCDC. difficulty/hard Hard task. severity/major type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

overvenus commented Jul 1, 2021 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

Running a changefeed that captures 6k tables.

With Unified Sorter W/O Unified Sorter
image image
25s 7s

By removed these lines, TiCDC backs to normal.

https://github.com/pingcap/ticdc/blob/284dd55766f4f57b4c3550057c219bd1c92e5331/cdc/puller/sorter/backend_pool.go#L136-L146

  1. What did you expect to see?

No keepalive dog timeout.

  1. What did you see instead?

keepalive dog timeout

  1. Versions of the cluster

release-5.0 and release-5.1
@overvenus overvenus added the type/bug The issue is confirmed as a bug. label Jul 1, 2021
@overvenus overvenus mentioned this issue Jul 4, 2021
Merged
@overvenus overvenus self-assigned this Jul 4, 2021
@overvenus overvenus mentioned this issue Jul 26, 2021
Closed
@overvenus
Copy link
Member Author

Following PR ues values in channel types to reduce GC pressure,

@overvenus overvenus added the difficulty/hard Hard task. label Aug 6, 2021
@overvenus
Copy link
Member Author

This issue also relates to #2553 .

This was referenced Sep 2, 2021
Merged
Merged
Merged
Merged
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@overvenus overvenus

Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 area/ticdc Issues or PRs related to TiCDC. difficulty/hard Hard task. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

puller/sorter: remove manual GC settings overvenus/ticdc
3 participants
@overvenus @AkiraXie @Tammyxia