Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv client v2 EventFeed RPC leaks #2284

Closed
overvenus opened this issue Jul 14, 2021 · 0 comments · Fixed by #2285
Closed

kv client v2 EventFeed RPC leaks #2284

overvenus opened this issue Jul 14, 2021 · 0 comments · Fixed by #2285
Assignees
@amyangfei
Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. difficulty/hard Hard task. severity/major type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

Replicating 6k tables using the commit d2c1aae, we find EventFeed rpc and its goroutine leaks.

From metrics we find, the leakage relates to eventfeed errors.

image

Based on pprof/trace, we find leaked goroutines are spawned at

https://github.com/pingcap/ticdc/blob/d2c1aaeb81561827cb67ceb6cd51cacc705e702a/cdc/kv/client.go#L855-L860
https://github.com/pingcap/ticdc/blob/d2c1aaeb81561827cb67ceb6cd51cacc705e702a/cdc/kv/region_worker.go#L546-L551

  1. What did you expect to see?

No leakage.

  1. What did you see instead?

Leakage.

  1. Versions of the cluster

A fork of v5.1.0 d2c1aae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyangfei amyangfei

Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. difficulty/hard Hard task. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kv/client: exit region worker if there is no region maintained amyangfei/tiflow
3 participants
@amyangfei @overvenus @AkiraXie