either reqCustomProps or customProps are valid #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `reqCustomProps(req,res)` to `customProps(req,res)` since `req` is not the only object from which it provides props. breaks: `reqCustomProps` usage, options signature will have to be changed to update
mcollina
requested changes
Feb 1, 2021
Either customProps or reqCustomProps will be valid
josh-hemphill
changed the title
mcollina
requested changes
Feb 2, 2021
Added a duplicate of the customProps function test for the old reqCustomProps interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the function's name no longer accurately represents its new signature, whenever there are other breaking changes to be made to the interface, this would be a good semantic change to also include.