Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

either reqCustomProps or customProps are valid #122

Merged
merged 4 commits into from
Feb 4, 2021
Merged

either reqCustomProps or customProps are valid #122

merged 4 commits into from
Feb 4, 2021

Commits on Jan 29, 2021

  1. feat: ✨ change custom props fn name to reflect signature 

    Changed `reqCustomProps(req,res)` to `customProps(req,res)` since `req` is not the only object from which it provides props.

breaks: `reqCustomProps` usage, options signature will have to be changed to update
    @josh-hemphill
    josh-hemphill committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    b1dc483 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. Merge commit 'bfd485e9426a7a6810dfa1c414aef715d236eeb5' into res-props

    @josh-hemphill
    josh-hemphill committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    bcbdd3f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. fix: props func as alias instead of replacing 

    Either customProps or reqCustomProps will be valid
    @josh-hemphill
    josh-hemphill committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    dbf97f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. test: added test for old interface 

    Added a duplicate of the customProps function test for the old reqCustomProps interface
    @josh-hemphill
    josh-hemphill committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1242ad9 View commit details
    Browse the repository at this point in the history