feature: quietReqLogger option for a quieter child logger available on the request object #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when enabled, will set request ids on log message with new overridable property 'reqId' (customAttributeKeys.reqId) - when enabled, will not bind request/customBindings on the child logger attached to the request object
jsumners
approved these changes
Sep 17, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've recently started using this for our logging as we migrated from bunyan to pino.
A behaviour we used to have in the bunyan-land was that our request logging middleware would similarly provide a request-context aware child logger (available at
req.log) however it would only contain the request id that you could use to filter logs on and see logs for the entire request transaction (including the one message with the full request serialized).Instead of just requesting this feature, I took a stab at a PR instead - please let me know if this is something you'd consider.
Some things that I'm on the fence/unsure about:
quietReqLogger🤷♂️res.logandreq.logare diverging with this option enabled, is there any downstream issues with this?