Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SourcingCheck does not work if additional packages are passed on command-line #688

Open
1 task done
mgorny opened this issue Jun 24, 2024 · 1 comment
Open
1 task done
Labels

Comments

@mgorny
Copy link
Contributor

mgorny commented Jun 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

$ pkgcheck scan -c SourcingCheck,VisibilityCheck dev-python/shiboken2
dev-python/shiboken2
  SourcingError: version 5.15.14: failed sourcing ebuild: LLVM_COMPAT does not contain any valid versions (all older than 16?), (llvm-r1.eclass, line 122:  called die)
$ pkgcheck scan -c SourcingCheck,VisibilityCheck dev-python/shiboken2 nonexist/nonexist --exit error
$ echo $?
0

This is with llvm-r1.eclass modified the following way:

diff --git a/eclass/llvm-r1.eclass b/eclass/llvm-r1.eclass
index 075df9218be8..2169157b5e08 100644
--- a/eclass/llvm-r1.eclass
+++ b/eclass/llvm-r1.eclass
@@ -54,7 +54,7 @@ inherit llvm-utils
 # @DESCRIPTION:
 # Oldest supported LLVM slot.  This is used to automatically filter out
 # unsupported LLVM_COMPAT values.
-_LLVM_OLDEST_SLOT=15
+_LLVM_OLDEST_SLOT=16
 
 # @ECLASS_VARIABLE: _LLVM_NEWEST_STABLE
 # @INTERNAL

Expected Behavior

SourcingError displayed for the matched package.

pkgcheck version

0.10.30

pkgcore version

0.12.27

@mgorny mgorny added the bug label Jun 24, 2024
@mgorny mgorny changed the title [Bug]: SourcingCheck does not work if non-existing package is passed on command-line [Bug]: SourcingCheck does not work if additional packages are passed on command-line Jun 24, 2024
@mgorny
Copy link
Contributor Author

mgorny commented Jun 24, 2024

Actually, it seems not to work for anything but the ultimate package:

$ pkgcheck scan -c SourcingCheck app-portage/flaggie dev-python/shiboken2
dev-python/shiboken2
  SourcingError: version 5.15.14: failed sourcing ebuild: LLVM_COMPAT does not contain any valid versions (all older than 16?), (llvm-r1.eclass, line 122:  called die)
$ pkgcheck scan -c SourcingCheck dev-python/shiboken2 app-portage/flaggie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant