From fe8fd288ccfea33bd620aaacb16d95c5a9c5cdbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Andr=C3=A9s=20L=C3=B3pez=20G=2E?= Date: Mon, 5 Aug 2024 11:23:22 -0500 Subject: [PATCH] fix: `shouldTrackEvents` method Now the `defaultPayload` and `Payload` are merged before sending to the validation `shouldTrack`. --- CHANGELOG.md | 6 ++++++ src/Trackers/MixpanelTracker.php | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f47fdbf..6a6b765 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [1.1.1] - 2024-08-05 + +### Changed + +- Fix `shouldTrackEvents` method. Now the `defaultPayload` and `Payload` are merged before sending to the validation `shouldTrack`. + ## [1.1.0] - 2024-08-02 ### Added diff --git a/src/Trackers/MixpanelTracker.php b/src/Trackers/MixpanelTracker.php index 5d8fba7..0c6a45b 100644 --- a/src/Trackers/MixpanelTracker.php +++ b/src/Trackers/MixpanelTracker.php @@ -32,8 +32,10 @@ public function track(string $label, array $payload = []): void return; } + $payload = array_merge($this->defaultPayload, $payload); + if ($this->shouldTrack($label, $payload)) { - $this->mixpanel->track($label, array_merge($this->defaultPayload, $payload)); + $this->mixpanel->track($label, $payload); } }