Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing an error without the full path can be confusing #1304

Closed
Ariakenom opened this issue Feb 8, 2024 · 0 comments
Closed

Showing an error without the full path can be confusing #1304

Ariakenom opened this issue Feb 8, 2024 · 0 comments

Comments

@Ariakenom
Copy link

Ariakenom commented Feb 8, 2024

I noticed this when I added quotes around my partition path in platformio.ini. I never noticed there was a quote in my file until after I found the issue, i just read right past it because paths often end in quotes. But the real issue is of course if the user has the wrong directory but right filename.

"Missing partition table file `%s`\n" % os.path.basename(pt_path)

Also this seems to choose built in files over an explicit custom one (if they happen to have the same name).

env.Replace(
PARTITIONS_TABLE_CSV=os.path.abspath(
os.path.join(fwpartitions_dir, partitions_csv)
if os.path.isfile(os.path.join(fwpartitions_dir, partitions_csv))
else partitions_csv
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant