PULL_REQUEST_TEMPLATE.md

@plentymarkets/team-terra

Definition of Done

Must be done by Terra

Testing

• Person 1 (mandatory)

  Browser support (relevant for changes in scss / appearance of components)

  • Chrome
  • Firefox
  • Safari

  Responsiveness

  • Desktop
  • Tablet
  • Mobile

• Person 2 (mandatory)

  Browser support

  • Chrome
  • Firefox
  • Safari

  Responsiveness

  • Desktop
  • Tablet
  • Mobile

Information transfer

• Inform Team plentyShop about changes in TerraFormComponent (optional: relevant for changes in this component)

Terra Basic Plugin

• Adapt changes (optional: relevant for version updates, global design changes, l10n)

---

Must be done by every developer

Please inform a member of Terra (@plentymarkets/team-terra) to get the upper part of the checklist done (with urgency or deadline).

Documentation

• Changelog (optional: relevant for every change which influences the API)
• Example (updated or created)
• JSDoc (optional: relevant for every change which influences the API)
• Google spreadsheet (relevant when deprecating public APIs or features)

Testing

• Unit Test (updated or created)