Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Properties modal or field settings modal regression. #570

Open
petschki opened this issue Jul 3, 2023 · 1 comment
Open

Editing Properties modal or field settings modal regression. #570

petschki opened this issue Jul 3, 2023 · 1 comment

Comments

@petschki
Copy link
Member

petschki commented Jul 3, 2023

During todays debugging session with @jensens and @gogo we found out that editing the properties modal and the field settings modal have the following regressions:

  • Since the original edit form is loaded and saved via GET/POST requests in mosaic.overlay.js the patterns aren't initialized correctly again in the .mosaic-original-content form. This leads to a JS error when saving the whole page.
  • Additionally the events are bound multiple times, so every time you edit your properties modal the reload event of the original content node gets duplicated 😰

Possible solution:

  • manipulate the .mosaic-original-content form values via JS when you edit Properties or field tile settings.
  • your idea here
@gogobd
Copy link
Contributor

gogobd commented Sep 27, 2023

This issue also affects RichText Fields in the Properties Form. Note that if inline mode is selected you won't get TinyMCE for RichText Fields in the Properties Form. When you disable inline mode the Editor will appear (workaround).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants