Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new choroplethmapbox locationmode for geojson properties.id #4154

Closed
cpsievert opened this issue Aug 29, 2019 · 5 comments · Fixed by #4419
Closed

Add new choroplethmapbox locationmode for geojson properties.id #4154

cpsievert opened this issue Aug 29, 2019 · 5 comments · Fixed by #4419
Assignees
@etpinard
Labels
feature something new
Milestone
v1.52.0

Comments

@cpsievert
Copy link

It seems like choroplethmapbox traces support MultiPolygons geometry types, but this example fails without error/warning:

https://codepen.io/cpsievert/pen/KKPqgje

Perhaps I am missing something?
@cpsievert
Copy link
Author

Interestingly, this same geojson file works as a layout.mapbox.layers -- https://codepen.io/cpsievert/pen/NWKgpzg

@etpinard
Copy link
Contributor

Looks like that geojson

https://gist.githubusercontent.com/cpsievert/66a06baaed96aa47e21ac02fd1d57efb/raw/8ee5ef67ac363910056f0c2aec896381c67a4d64/huh.json

doesn't set any feature id fields. It does set properties.id, but we unfortunately don't support extracting data for properties.id yet. It would be a nice addition to the library though.

@cpsievert cpsievert changed the title choroplethmapbox with MultiPolygons choroplethmapbox doesn't render without feature id fields Aug 29, 2019
@cpsievert
Copy link
Author

Ahh, thanks for catching that!

@etpinard
Copy link
Contributor

No problem @cpsievert - ok if I turned this into a type: feature ticket?

@cpsievert
Copy link
Author

👍

@etpinard etpinard changed the title choroplethmapbox doesn't render without feature id fields Add new choroplethmapbox locationmode for geojson properties.id Aug 29, 2019
@etpinard etpinard added the feature something new label Aug 29, 2019
@etpinard etpinard added this to the v1.52.0 milestone Nov 29, 2019
@etpinard etpinard self-assigned this Nov 29, 2019
@etpinard etpinard mentioned this issue Dec 11, 2019
Merged
1 task
@huonw huonw mentioned this issue Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
feature something new
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging a pull request may close this issue.

Geo improvements: fitbounds, 'geojson-id' locationmode and 'featureidkey' plotly/plotly.js
2 participants
@cpsievert @etpinard