Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dashboard search doesn't work #7172

Closed
marthacryan opened this issue Sep 24, 2024 · 1 comment · Fixed by #7180
Closed

Test dashboard search doesn't work #7172

marthacryan opened this issue Sep 24, 2024 · 1 comment · Fixed by #7180
Assignees
Labels
P2 needed for current cycle

Comments

@marthacryan
Copy link
Contributor

marthacryan commented Sep 24, 2024

Steps to reproduce:

  • clone plotly.js repo (if you already have it cloned, do a git clean)
  • npm i
  • npm start
  • The mock search doesn't work

This is due to the esbuild changes - #6909. That PR removed the generation of the build/test_dashboard-bundle.js file, which is essential to using the test dashboard.

This wasn't caught when testing that PR (or as we've been continuing development) because the file remained locally, but if you clone the repo, the test dashboard doesn't work anymore.

@marthacryan marthacryan added the P2 needed for current cycle label Sep 24, 2024
@emilykl
Copy link
Contributor

emilykl commented Sep 24, 2024

Thanks for opening this issue Martha! I ran into this but hadn't gotten around to investigating yet.

The individual mocks can be accessed by typing in the URL directly, but the search is broken.

@marthacryan marthacryan changed the title Test dashboard doesn't work Test dashboard search doesn't work Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 needed for current cycle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants