Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective retry v2 API requests #1114

Closed
jonmmease opened this issue Aug 15, 2018 · 1 comment
Closed

Selective retry v2 API requests #1114

jonmmease opened this issue Aug 15, 2018 · 1 comment
Milestone

Comments

@jonmmease
Copy link
Contributor

In version 3 we introduced automatic retrying logic for all v2 REST API calls to plot.ly. This has improved the reliability and reduced the incidence of failures do to intermittent server connectivity issues.

But, we're currently retrying on all requests, even cases where there's really no point (e.g. an error due to an invalid figure URL isn't going to go away by retrying many times).

As a starting point, let's keep retrying on 5XX errors, stop retrying on the 4XX errors, and investigate the nature of the 2XX errors that still occur.

This should hopefully reduce the runtime of our test suite and maintain the reliability of retrying when appropriate.

@jonmmease
Copy link
Contributor Author

Done in #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant