From a50fe20c14300e397fefbddaf64485de2290abfa Mon Sep 17 00:00:00 2001
From: LAUNAY Samuel <107540223+Lainow@users.noreply.github.com>
Date: Fri, 17 May 2024 14:29:27 +0200
Subject: [PATCH] Fix(Core): Fix behavior of "Display delete button" option

---
 CHANGELOG.md         |   6 +
 inc/ticket.class.php | 317 ++++++++++++++++++++++---------------------
 js/remove_btn.js.php |  98 +++++++++++++
 3 files changed, 263 insertions(+), 158 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e00eeb3..9eb9075 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [unreleased]
+
+### Fixed
+
+- Fix ```Display delete button``` option
+
 ## [2.9.5] - 2024-05-06
 
 ### Fixed
diff --git a/inc/ticket.class.php b/inc/ticket.class.php
index 3313e16..653fa48 100644
--- a/inc/ticket.class.php
+++ b/inc/ticket.class.php
@@ -38,18 +38,17 @@ class PluginEscaladeTicket
 {
     public static function pre_item_update(CommonDBTM $item)
     {
-       //only if update is related to Group assign operation and _from_assignment
+        //only if update is related to Group assign operation and _from_assignment
         if (
             !empty(array_filter(
                 $item->input['_actors']['assign'] ?? [],
                 fn ($actor) => $actor['itemtype'] == 'Group'
-            ))
-            && (
+            )) && (
                 isset($item->input['_from_assignment'])
                 && $item->input['_from_assignment']
             )
         ) {
-           //handle status behavior
+            //handle status behavior
             if ($_SESSION['plugins']['escalade']['config']['ticket_last_status'] != -1) {
                 $item->input['status'] = $_SESSION['plugins']['escalade']['config']['ticket_last_status'];
             }
@@ -58,7 +57,6 @@ public static function pre_item_update(CommonDBTM $item)
         if (isset($input['_itil_assign'])) {
             $item->input['_do_not_compute_status'] = true;
         }
-
         $config = $_SESSION['plugins']['escalade']['config'];
 
         // Get actual actors for the ticket
@@ -106,16 +104,16 @@ function ($carry, $type) use ($item) {
         }
     }
 
-   /**
-    * Provide a redirection to other functions
-    * @param  CommonDBTM $item
-    * @return void
-    */
+    /**
+     * Provide a redirection to other functions
+     * @param  CommonDBTM $item
+     * @return void
+     */
     public static function item_update(CommonDBTM $item)
     {
 
         if ($_SESSION['plugins']['escalade']['config']['remove_group']) {
-           //solve ticket
+            //solve ticket
             if (isset($item->input['status']) && $item->input['status'] == CommonITILObject::SOLVED) {
                 self::AssignFirstGroupOnSolve($item);
 
@@ -128,9 +126,9 @@ public static function item_update(CommonDBTM $item)
                 }
             }
 
-           //close ticket
+            //close ticket
             if (isset($item->input['status']) && $item->input['status'] == CommonITILObject::CLOSED) {
-               //close linked tickets
+                //close linked tickets
                 self::linkedTickets($item, CommonITILObject::CLOSED);
             } else if (
                 isset($item->input['status'])
@@ -138,27 +136,27 @@ public static function item_update(CommonDBTM $item)
                 && isset($item->oldvalues['status'])
                 && $item->oldvalues['status'] == CommonITILObject::SOLVED
             ) {
-               //solution rejected
+                //solution rejected
                 self::AssignLastGroupOnRejectedSolution($item);
             }
         }
 
-       //ticket qualification on cat change
+        //ticket qualification on cat change
         if (isset($item->input['itilcategories_id'])) {
             self::qualification($item);
         }
 
-       // notification on solve date modification
+        // notification on solve date modification
         if (in_array('solvedate', $item->updates)) {
             NotificationEvent::raiseEvent('update_solvedate', $item);
         }
     }
 
 
-   /**
-    * When a ticket is solved, if group histories exists, assign the first group on the ticket
-    * @param CommonDBTM $item the ticket object
-    */
+    /**
+     * When a ticket is solved, if group histories exists, assign the first group on the ticket
+     * @param CommonDBTM $item the ticket object
+     */
     public static function AssignFirstGroupOnSolve(CommonDBTM $item)
     {
         if (
@@ -170,11 +168,11 @@ public static function AssignFirstGroupOnSolve(CommonDBTM $item)
             $first_history = PluginEscaladeHistory::getFirstLineForTicket($tickets_id);
             $last_history  = PluginEscaladeHistory::getLastLineForTicket($tickets_id);
 
-           //if no history
+            //if no history
             if ($first_history === false) {
                 return;
             }
-           //if first history group == last history group
+            //if first history group == last history group
             if ($first_history['id'] == $last_history['id']) {
                 return;
             }
@@ -182,10 +180,10 @@ public static function AssignFirstGroupOnSolve(CommonDBTM $item)
             self::removeAssignGroups($tickets_id, $first_history['groups_id']);
             self::removeAssignUsers($tickets_id);
 
-           //set session var to prevent double task message
+            //set session var to prevent double task message
             $_SESSION['plugin_escalade']['solution'] = true;
 
-           //add the first history group (if not already exist)
+            //add the first history group (if not already exist)
             $group_ticket = new Group_Ticket();
             $condition = [
                 'tickets_id' => $tickets_id,
@@ -196,7 +194,7 @@ public static function AssignFirstGroupOnSolve(CommonDBTM $item)
                 $group_ticket->add($condition);
             }
 
-           //add a task to inform the escalation
+            //add a task to inform the escalation
             if ($_SESSION['plugins']['escalade']['config']['task_history']) {
                 $group = new Group();
                 $group->getFromDB($first_history['groups_id']);
@@ -207,18 +205,18 @@ public static function AssignFirstGroupOnSolve(CommonDBTM $item)
                     '_no_reopen' => true, //prevent reopening ticket
                     'state'      => Planning::INFO,
                     'content'    => __("Solution provided, back to the group", "escalade") . " " .
-                               $group->getName()
+                        $group->getName()
                 ]);
             }
         }
     }
 
 
-   /**
-    * When a ticket solution is rejected, if group histories exists,
-    * assign the last group on the ticket
-    * @param CommonDBTM $item the ticket object
-    */
+    /**
+     * When a ticket solution is rejected, if group histories exists,
+     * assign the last group on the ticket
+     * @param CommonDBTM $item the ticket object
+     */
     public static function AssignLastGroupOnRejectedSolution(CommonDBTM $item)
     {
         if (!isset($_POST['add_reopen'])) {
@@ -239,21 +237,21 @@ public static function AssignLastGroupOnRejectedSolution(CommonDBTM $item)
             array_shift($full_history); //remove current group in history
             $rejected_history = array_shift($full_history); // get previous group
 
-           //if no history
+            //if no history
             if ($last_history === false) {
                 return;
             }
-           //if first history group == last history group
+            //if first history group == last history group
             if ($rejected_history['id'] == $last_history['id']) {
                 return;
             }
 
             self::removeAssignGroups($tickets_id, $rejected_history['groups_id']);
 
-           //set session var to prevent double task message
+            //set session var to prevent double task message
             $_SESSION['plugin_escalade']['solution'] = true;
 
-           //add the first history group
+            //add the first history group
             $group_ticket = new Group_Ticket();
             $group_ticket->add([
                 'tickets_id' => $tickets_id,
@@ -261,7 +259,7 @@ public static function AssignLastGroupOnRejectedSolution(CommonDBTM $item)
                 'type'       => CommonITILActor::ASSIGN
             ]);
 
-           //add a task to inform the escalation
+            //add a task to inform the escalation
             if ($_SESSION['plugins']['escalade']['config']['task_history']) {
                 $group = new Group();
                 $group->getFromDB($rejected_history['groups_id']);
@@ -271,11 +269,11 @@ public static function AssignLastGroupOnRejectedSolution(CommonDBTM $item)
                     'is_private' => true,
                     'state'      => Planning::INFO,
                     'content'    => __("Solution rejected, return to the group", "escalade") . " " .
-                               $group->getName()
+                        $group->getName()
                 ]);
             }
 
-           //update status
+            //update status
             if ($_SESSION['plugins']['escalade']['config']['ticket_last_status'] != -1) {
                 $item->update([
                     'id' => $tickets_id,
@@ -286,11 +284,11 @@ public static function AssignLastGroupOnRejectedSolution(CommonDBTM $item)
     }
 
 
-   /**
-    *  remove old groups to a ticket when a new group assigned
-    *  called by "pre_item_add" hook on Group_Ticket object
-    * @param CommonDBTM $item the ticket object
-    */
+    /**
+     *  remove old groups to a ticket when a new group assigned
+     *  called by "pre_item_add" hook on Group_Ticket object
+     * @param CommonDBTM $item the ticket object
+     */
     public static function addHistoryOnAddGroup(CommonDBTM $item)
     {
         /** @var DBmysql $DB */
@@ -300,7 +298,7 @@ public static function addHistoryOnAddGroup(CommonDBTM $item)
             return true;
         }
 
-       //if group sent is not an assign group, return
+        //if group sent is not an assign group, return
         if ($item->input['type'] != CommonITILActor::ASSIGN) {
             return;
         }
@@ -308,7 +306,7 @@ public static function addHistoryOnAddGroup(CommonDBTM $item)
         $tickets_id = $item->input['tickets_id'];
         $groups_id  = $item->input['groups_id'];
 
-       //if group already assigned, return
+        //if group already assigned, return
         $group_ticket = new Group_Ticket();
         $condition = [
             'tickets_id' => $tickets_id,
@@ -322,11 +320,12 @@ public static function addHistoryOnAddGroup(CommonDBTM $item)
 
         $item->fields['status'] = CommonITILObject::ASSIGNED;
 
-       //add line in history table
+        //add line in history table
         $history = new PluginEscaladeHistory();
 
         $group_ticket       = new Group_Ticket();
-        $group_ticket->getFromDBByRequest(['ORDER'   => 'id DESC',
+        $group_ticket->getFromDBByRequest([
+            'ORDER'   => 'id DESC',
             'LIMIT'      => 1,
             'tickets_id' => $tickets_id,
             'type'       => 2
@@ -352,8 +351,8 @@ public static function addHistoryOnAddGroup(CommonDBTM $item)
             'counter'            => $counter
         ]);
 
-       // check if group assignment is made during ticket creation
-       // in this case, skip following steps as it cannot be considered as a group escalation
+        // check if group assignment is made during ticket creation
+        // in this case, skip following steps as it cannot be considered as a group escalation
         $backtraces   = debug_backtrace();
         foreach ($backtraces as $backtrace) {
             if (
@@ -365,10 +364,10 @@ public static function addHistoryOnAddGroup(CommonDBTM $item)
             }
         }
 
-       //remove old user(s) (pass if user added by new ticket)
+        //remove old user(s) (pass if user added by new ticket)
         self::removeAssignUsers($tickets_id);
 
-       //add a task to inform the escalation (pass if solution)
+        //add a task to inform the escalation (pass if solution)
         if (isset($_SESSION['plugin_escalade']['solution'])) {
             unset($_SESSION['plugin_escalade']['solution']);
             return $item;
@@ -419,18 +418,18 @@ public static function processAfterAddGroup(CommonDBTM $item)
     }
 
 
-   /**
-   * @param Ticket $ticket
-   * @return bool
-   */
+    /**
+     * @param Ticket $ticket
+     * @return bool
+     */
     public static function assignUserGroup(Ticket $ticket)
     {
         if (!is_array($ticket->input) || !count($ticket->input)) {
-           // Already cancel by another plugin
+            // Already cancel by another plugin
             return false;
         }
 
-       //check plugin behaviors (for avoid conflict)
+        //check plugin behaviors (for avoid conflict)
         if (Plugin::isPluginActive('behaviors')) {
             // @phpstan-ignore-next-line
             $behavior_config = PluginBehaviorsConfig::getInstance();
@@ -439,7 +438,7 @@ public static function assignUserGroup(Ticket $ticket)
             }
         }
 
-       //check this plugin config
+        //check this plugin config
         if (
             $_SESSION['plugins']['escalade']['config']['use_assign_user_group'] == 0
             || $_SESSION['plugins']['escalade']['config']['use_assign_user_group_creation'] == 0
@@ -451,29 +450,29 @@ public static function assignUserGroup(Ticket $ticket)
             isset($ticket->input['_users_id_assign'])
             && $ticket->input['_users_id_assign'] > 0
             && (!isset($ticket->input['_groups_id_assign'])
-            || $ticket->input['_groups_id_assign'] <= 0)
+                || $ticket->input['_groups_id_assign'] <= 0)
         ) {
             if ($_SESSION['plugins']['escalade']['config']['use_assign_user_group'] == 1) {
-               // First group
+                // First group
                 $ticket->input['_groups_id_assign']
-                = PluginEscaladeUser::getTechnicianGroup(
-                    $ticket->input['entities_id'],
-                    $ticket->input['_users_id_assign'],
-                    true
-                );
-               //prevent adding empty group
+                    = PluginEscaladeUser::getTechnicianGroup(
+                        $ticket->input['entities_id'],
+                        $ticket->input['_users_id_assign'],
+                        true
+                    );
+                //prevent adding empty group
                 if (empty($ticket->input['_groups_id_assign'])) {
-                     unset($ticket->input['_groups_id_assign']);
+                    unset($ticket->input['_groups_id_assign']);
                 }
             } else {
-               // All groups
+                // All groups
                 $ticket->input['_additional_groups_assigns']
-                = PluginEscaladeUser::getTechnicianGroup(
-                    $ticket->input['entities_id'],
-                    $ticket->input['_users_id_assign'],
-                    false
-                );
-               //prevent adding empty group
+                    = PluginEscaladeUser::getTechnicianGroup(
+                        $ticket->input['entities_id'],
+                        $ticket->input['_users_id_assign'],
+                        false
+                    );
+                //prevent adding empty group
                 if (empty($ticket->input['_additional_groups_assigns'])) {
                     unset($ticket->input['_additional_groups_assigns']);
                 }
@@ -483,23 +482,23 @@ public static function assignUserGroup(Ticket $ticket)
         return true;
     }
 
-   /**
-    * assign a previous group to the ticket
-    * @param  int $tickets_id the ticket to change
-    * @param  int $groups_id  the group to assign
-    * @return void
-    */
+    /**
+     * assign a previous group to the ticket
+     * @param  int $tickets_id the ticket to change
+     * @param  int $groups_id  the group to assign
+     * @return void
+     */
     public static function climb_group($tickets_id, $groups_id, $full_history = false)
     {
-       //don't add group if already exist for this ticket
+        //don't add group if already exist for this ticket
         $group_ticket = new Group_Ticket();
         $condition = [
             'tickets_id' => $tickets_id,
             'groups_id'  => $groups_id,
             'type'       => CommonITILActor::ASSIGN
         ];
-        if (! $group_ticket->find($condition)) {
-           // add group to ticket
+        if (!$group_ticket->find($condition)) {
+            // add group to ticket
             $group_ticket_input = [
                 'type'       => CommonITILActor::ASSIGN,
                 'groups_id'  => $groups_id,
@@ -507,7 +506,7 @@ public static function climb_group($tickets_id, $groups_id, $full_history = fals
                 '_plugin_escalade_no_history' => true, // Prevent a duplicated task to be added
             ];
 
-           //handle status behavior
+            //handle status behavior
             if ($_SESSION['plugins']['escalade']['config']['ticket_last_status'] != -1) {
                 $group_ticket_input['_from_object']['status'] = $_SESSION['plugins']['escalade']['config']['ticket_last_status'];
             }
@@ -518,10 +517,10 @@ public static function climb_group($tickets_id, $groups_id, $full_history = fals
             $group_ticket->add($group_ticket_input);
         }
 
-        if (! $full_history) {
+        if (!$full_history) {
             Html::back();
         } else {
-           //reload parent window and close popup
+            //reload parent window and close popup
             echo "<script type='text/javascript'>
             if (window.opener && !window.opener.closed) {
                window.opener.location.reload();
@@ -532,11 +531,11 @@ public static function climb_group($tickets_id, $groups_id, $full_history = fals
     }
 
 
-   /**
-    * Clean all assigned groups for the ticket
-    * @param  int $tickets_id
-    * @return void
-    */
+    /**
+     * Clean all assigned groups for the ticket
+     * @param  int $tickets_id
+     * @return void
+     */
     public static function removeAssignGroups($tickets_id, $keep_groups_id = false)
     {
         $where_keep = [
@@ -553,16 +552,16 @@ public static function removeAssignGroups($tickets_id, $keep_groups_id = false)
             $group_ticket->delete($gt);
         }
 
-       //add a var to prevent status changes unwanted
+        //add a var to prevent status changes unwanted
         $_SESSION['plugin_escalade']['remove_assign'] = true;
     }
 
 
-   /**
-    * Clean all assigned users for the ticket
-    * @param  int $tickets_id
-    * @return void
-    */
+    /**
+     * Clean all assigned users for the ticket
+     * @param  int $tickets_id
+     * @return void
+     */
     public static function removeAssignUsers($tickets_id, $keep_users_id = false, $type = CommonITILActor::ASSIGN)
     {
         if (
@@ -589,7 +588,7 @@ public static function removeAssignUsers($tickets_id, $keep_users_id = false, $t
         $ticket_user = new Ticket_User();
         $found = $ticket_user->find($where_keep);
         foreach ($found as $id => $tu) {
-           //if user must be keeped (see item_add_user function)
+            //if user must be keeped (see item_add_user function)
             if (
                 isset($_SESSION['plugin_escalade']['keep_users'])
                 && is_array($_SESSION['plugin_escalade']['keep_users'])
@@ -598,24 +597,24 @@ public static function removeAssignUsers($tickets_id, $keep_users_id = false, $t
                 continue;
             }
 
-           //delete user
+            //delete user
             $ticket_user->delete(['id' => $id]);
         }
 
-       //clean session var (to prevent users be keeped post to this ticket update)
+        //clean session var (to prevent users be keeped post to this ticket update)
         unset($_SESSION['plugin_escalade']['keep_users']);
 
-       //add a var to prevent status changes unwanted
+        //add a var to prevent status changes unwanted
         $_SESSION['plugin_escalade']['remove_assign'] = true;
     }
 
 
-   /**
-    * Update ticket status when user added.
-    * Trigger also adding user groups if feature enabled
-    * @param  Ticket_User $item Ticket_User object
-    * @return void
-    */
+    /**
+     * Update ticket status when user added.
+     * Trigger also adding user groups if feature enabled
+     * @param  Ticket_User $item Ticket_User object
+     * @return void
+     */
     public static function item_add_user(Ticket_User $item, $type = CommonITILActor::ASSIGN)
     {
         $users_id   = $item->input['users_id'];
@@ -626,8 +625,8 @@ public static function item_add_user(Ticket_User $item, $type = CommonITILActor:
 
         self::removeAssignUsers($tickets_id, $users_id, $type);
 
-       // == Add user groups on modification ==
-       //check this plugin config
+        // == Add user groups on modification ==
+        //check this plugin config
         if (
             $_SESSION['plugins']['escalade']['config']['use_assign_user_group'] == 0
             || $_SESSION['plugins']['escalade']['config']['use_assign_user_group_modification'] == 0
@@ -636,14 +635,14 @@ public static function item_add_user(Ticket_User $item, $type = CommonITILActor:
         }
 
         if ($_SESSION['plugins']['escalade']['config']['use_assign_user_group'] == 1) {
-           // First group
+            // First group
             $groups_id = PluginEscaladeUser::getTechnicianGroup(
                 $ticket->fields['entities_id'],
                 $item->fields['users_id'],
                 true
             );
         } else {
-           // All groups
+            // All groups
             $groups_id = PluginEscaladeUser::getTechnicianGroup(
                 $ticket->fields['entities_id'],
                 $item->fields['users_id'],
@@ -654,8 +653,9 @@ public static function item_add_user(Ticket_User $item, $type = CommonITILActor:
         if (!empty($groups_id)) {
             $group_ticket = new Group_Ticket();
 
-           //The ticket cannot have this group already assigned
-            $found = $group_ticket->find(['tickets_id' => $tickets_id,
+            //The ticket cannot have this group already assigned
+            $found = $group_ticket->find([
+                'tickets_id' => $tickets_id,
                 'groups_id'  => $groups_id,
                 'type'       => CommonITILActor::ASSIGN
             ]);
@@ -663,11 +663,11 @@ public static function item_add_user(Ticket_User $item, $type = CommonITILActor:
                 return;
             }
 
-           //prevent user removal
+            //prevent user removal
             $_SESSION['plugin_escalade']['keep_users'][$item->fields['users_id']]
-            = $item->fields['users_id'];
+                = $item->fields['users_id'];
 
-           //add new group to ticket
+            //add new group to ticket
             $group_ticket->add([
                 'tickets_id' => $tickets_id,
                 'groups_id'  => $groups_id,
@@ -679,7 +679,7 @@ public static function item_add_user(Ticket_User $item, $type = CommonITILActor:
             }
         }
 
-       //fix ticket status
+        //fix ticket status
         $ticket->update([
             'id'     => $tickets_id,
             'status' => CommonITILObject::ASSIGNED
@@ -687,11 +687,11 @@ public static function item_add_user(Ticket_User $item, $type = CommonITILActor:
     }
 
 
-   /**
-    * Close linked tickets when ticket passed in parameter is closed
-    * @param  CommonDBTM $item the ticket object
-    * @return void
-    */
+    /**
+     * Close linked tickets when ticket passed in parameter is closed
+     * @param  CommonDBTM $item the ticket object
+     * @return void
+     */
     public static function linkedTickets(CommonDBTM $ticket, $status = CommonITILObject::SOLVED)
     {
         if ($_SESSION['plugins']['escalade']['config']['close_linkedtickets']) {
@@ -716,34 +716,34 @@ public static function linkedTickets(CommonDBTM $ticket, $status = CommonITILObj
     }
 
 
-   /**
-    * On ticket category change, add ticket category group and user
-    * @param  CommonDBTM $item
-    * @return void
-    */
+    /**
+     * On ticket category change, add ticket category group and user
+     * @param  CommonDBTM $item
+     * @return void
+     */
     public static function qualification(CommonDBTM $item)
     {
         /** @var DBmysql $DB */
         global $DB;
 
-       //get auto-assign mode (config in entity)
+        //get auto-assign mode (config in entity)
         $auto_assign_mode = Entity::getUsedConfig('auto_assign_mode', $_SESSION['glpiactive_entity']);
         if ($auto_assign_mode == Entity::CONFIG_NEVER) {
             return true;
         }
 
-       //get category
+        //get category
         $category = new ITILCategory();
         $category->getFromDB($item->input['itilcategories_id']);
 
-       //category group
+        //category group
         if (
             !empty($category->fields['groups_id'])
             && $_SESSION['plugins']['escalade']['config']['reassign_group_from_cat']
         ) {
             $group_ticket = new Group_Ticket();
 
-           //check if group is not already present
+            //check if group is not already present
             $group_condition = [
                 'tickets_id' => $item->fields['id'],
                 'groups_id'  => $category->fields['groups_id'],
@@ -766,14 +766,14 @@ public static function qualification(CommonDBTM $item)
             }
         }
 
-       //category user
+        //category user
         if (
             !empty($category->fields['users_id'])
             && $_SESSION['plugins']['escalade']['config']['reassign_tech_from_cat']
         ) {
             $ticket_user = new Ticket_User();
 
-           //check if user is not already present
+            //check if user is not already present
             $user_condition = [
                 'tickets_id' => $item->fields['id'],
                 'users_id'   => $category->fields['users_id'],
@@ -781,7 +781,7 @@ public static function qualification(CommonDBTM $item)
             ];
             $user_found = $ticket_user->find($user_condition);
             if (empty($user_found)) {
-               //add user to ticket
+                //add user to ticket
                 $ticket_user->add($user_condition);
                 //remove old tech if needed
                 if ($_SESSION['plugins']['escalade']['config']['remove_tech']) {
@@ -798,40 +798,40 @@ public static function qualification(CommonDBTM $item)
     }
 
 
-   /**
-    * CLone a ticket and his relations
-    * @param  integer $tickets_id id of the ticket to clone
-    * @return void print a json response (return nothing)
-    */
+    /**
+     * CLone a ticket and his relations
+     * @param  integer $tickets_id id of the ticket to clone
+     * @return void print a json response (return nothing)
+     */
     public static function cloneAndLink($tickets_id)
     {
         /** @var DBmysql $DB */
         global $DB;
 
-       //get old ticket
+        //get old ticket
         $ticket = new Ticket();
         if (!$ticket->getFromDB($tickets_id)) {
             Session::addMessageAfterRedirect(__('Error : get old ticket', 'escalade'), false, ERROR);
             exit;
         }
 
-       //set fields
+        //set fields
         $fields = $ticket->fields;
         $fields = array_map(['Toolbox', 'addslashes_deep'], $fields);
         $fields['id']                  = 0;
         $fields['_users_id_requester'] = 0;
         $fields['status']              = CommonITILObject::INCOMING;
 
-       /*var_dump($fields);
+        /*var_dump($fields);
        exit;*/
 
-       //create new ticket (duplicate from previous)
-        if (! $newID = $ticket->add($fields)) {
+        //create new ticket (duplicate from previous)
+        if (!$newID = $ticket->add($fields)) {
             Session::addMessageAfterRedirect(__('Error : adding new ticket', 'escalade'), false, ERROR);
             exit;
         }
 
-       //add link between them
+        //add link between them
         $ticket_ticket = new Ticket_Ticket();
         if (
             !$ticket_ticket->add([
@@ -844,15 +844,15 @@ public static function cloneAndLink($tickets_id)
             exit;
         }
 
-       //add a followup to indicate duplication
+        //add a followup to indicate duplication
         $followup = new ITILFollowup();
         if (
-            ! $followup->add([
+            !$followup->add([
                 'items_id'        => $newID,
                 'itemtype'        => Ticket::class,
                 'users_id'        => Session::getLoginUserID(),
                 'content'         => __("This ticket has been cloned from the ticket num", "escalade") . " " .
-                              $tickets_id,
+                    $tickets_id,
                 'is_private'      => true,
                 'requesttypes_id' => 6 //other
             ])
@@ -861,8 +861,8 @@ public static function cloneAndLink($tickets_id)
             exit;
         }
 
-       //add actors to the new ticket (without assign)
-       //users
+        //add actors to the new ticket (without assign)
+        //users
         $query_users = "INSERT INTO glpi_tickets_users
       SELECT null AS id, $newID as tickets_id, users_id, type, use_notification, alternative_email
       FROM glpi_tickets_users
@@ -872,7 +872,7 @@ public static function cloneAndLink($tickets_id)
             Session::addMessageAfterRedirect(__('Error : adding actors (user)', 'escalade'), false, ERROR);
             exit;
         }
-       //groups
+        //groups
         $query_groups = "INSERT INTO glpi_groups_tickets
       SELECT null AS id, $newID as tickets_id, groups_id, type
       FROM glpi_groups_tickets
@@ -883,28 +883,28 @@ public static function cloneAndLink($tickets_id)
             exit;
         }
 
-       //add documents
+        //add documents
         $query_docs = "INSERT INTO glpi_documents_items (documents_id, items_id, itemtype, entities_id, is_recursive, date_mod)
       SELECT documents_id, $newID, 'Ticket', entities_id, is_recursive, date_mod
       FROM glpi_documents_items
       WHERE items_id = $tickets_id AND itemtype = 'Ticket'";
         // @phpstan-ignore-next-line
-        if (! $res = $DB->query($query_docs)) {
+        if (!$res = $DB->query($query_docs)) {
             Session::addMessageAfterRedirect(__('Error : adding documents', 'escalade'), false, ERROR);
             exit;
         }
 
-       //add history to the new ticket
+        //add history to the new ticket
         $changes[0] = '0';
         $changes[1] = __("This ticket has been cloned from the ticket num", "escalade") . " " . $tickets_id;
         $changes[2] = "";
         Log::history($newID, 'Ticket', $changes, 'Ticket');
 
-       //add message (ticket cloned) after redirect
+        //add message (ticket cloned) after redirect
         Session::addMessageAfterRedirect(__("This ticket has been cloned from the ticket num", "escalade") .
-                                       " " . $tickets_id);
+            " " . $tickets_id);
 
-       //all ok
+        //all ok
         echo "{\"success\":true, \"newID\":$newID}";
     }
 
@@ -913,7 +913,8 @@ public static function assign_me($tickets_id)
     {
 
         $tu = new Ticket_User();
-        $found = $tu->find(['tickets_id' => $tickets_id,
+        $found = $tu->find([
+            'tickets_id' => $tickets_id,
             'users_id'   => $_SESSION['glpiID'],
             'type'       => CommonITILActor::ASSIGN
         ]);
diff --git a/js/remove_btn.js.php b/js/remove_btn.js.php
index 6dbb916..a4f852d 100644
--- a/js/remove_btn.js.php
+++ b/js/remove_btn.js.php
@@ -115,6 +115,60 @@
       return true;
    }
 
+   let getActorsAlreadyPresent = function(buttons_to_delete) {
+      let actors = [];
+      for (const [itemtype, actortypes] of Object.entries(buttons_to_delete)) {
+         for (const [actortype, to_delete] of Object.entries(actortypes)) {
+               if (to_delete) {
+                  let requester_form = $('.form-select.select2-hidden-accessible[data-actor-type='+actortype+']');
+                  let select2_input = requester_form.next('.select2-container').find('.select2-selection.select2-selection--multiple.actor-field');
+                  let select2_choices = select2_input.find('span.actor_entry');
+                  if (!actors[actortype]) {
+                     actors[actortype] = [];
+                  }
+                  select2_choices.each(function() {
+                     let item_id = $(this).data('items-id');
+                     let itemtype = $(this).data('itemtype');
+                     let exists = actors[actortype].some(el => el.item_id === item_id && el.itemtype === itemtype);
+
+                     if (!exists) {
+                           actors[actortype].push({
+                              item_id: item_id,
+                              itemtype: itemtype
+                           });
+                     }
+                  });
+               }
+         }
+      }
+      return actors;
+   }
+
+   var removeDeleteButtonForPreviousActors = function(actorslist) {
+      for (const actortype of actorslist) {
+         var requester_form = $(".form-select.select2-hidden-accessible[data-actor-type="+actortype+"]");
+         requester_form.on('select2:selecting', handleEvent);
+         requester_form.on('select2:open', handleEvent);
+         function handleEvent() {
+            for(const [item_id, itemtype] of actortype) {
+               setTimeout(function() {
+                  removeDeleteButtonForOne(itemtype, item_id, actortype, requester_form);
+               }, 50);
+            }
+         }
+      }
+   }
+
+   var removeDeleteButtonForOne = function(itemtype, item_id, actortype, form) {
+      var select2_container = form.next('.select2-container');
+      var select2_choice = select2_container.find(".select2-selection.select2-selection--multiple.actor-field span.actor_entry[data-itemtype="+itemtype+"][data-items-id="+item_id+"][data-actortype="+actortype+"]").first();
+      // Remove "x" from select2 tag
+      select2_choice.prev('.select2-selection__choice__remove').remove();
+
+      // Data is loaded
+      return true;
+   }
+
    var removeAllDeleteButtons = function(buttons_to_delete) {
       // Iterate on all itemtype + actortype combinations
       for (const [itemtype, actortypes] of Object.entries(buttons_to_delete)) {
@@ -129,6 +183,20 @@
       return buttons_to_delete;
    }
 
+   var actorCanBeRemoved = function(actortype, data, actors) {
+      if (actors === undefined || actors === null || data.id === undefined || data.id === null) {
+         return false;
+      }
+      var parts = data.id.split("_");
+      var item_id = parts[1];
+      var itemtype = parts[0];
+      var actorValues = Object.values(actors);
+      var exists = actorValues.some(function(el) {
+         return el.item_id == item_id && el.itemtype == itemtype;
+      });
+      return exists;
+   }
+
    $(document).ready(function() {
       // only in ticket form
       if (location.pathname.indexOf('ticket.form.php') > 0
@@ -150,6 +218,36 @@
                   assign: {$remove_delete_assign_supplier_btn},
                }
             };
+
+            var actors = getActorsAlreadyPresent(buttons_to_delete);
+            function handleRemoveDeletebuttonForOne(actortype_key, form) {
+               return function() {
+                  if (actors[actortype_key] === null || actors[actortype_key] === undefined ) {
+                     return false;
+                  }
+                  for(const [item_key, item_value] of Object.entries(actors[actortype_key])) {
+                     setTimeout(function() {
+                        removeDeleteButtonForOne(item_value['itemtype'], item_value['item_id'], actortype_key, form);
+                     }, 50);
+                  }
+               }
+            }
+
+            var actortypes = ['assign', 'requester', 'observer'];
+            for (var i = 0; i < actortypes.length; i++) {
+               let form = $(".form-select.select2-hidden-accessible[data-actor-type='" + actortypes[i] + "']");
+
+               form.on('select2:select', handleRemoveDeletebuttonForOne(actortypes[i], form));
+               form.on('select2:open', handleRemoveDeletebuttonForOne(actortypes[i], form));
+               form.on('select2:unselecting', function(e) {
+                  let data = e.params.args.data;
+                  let actortype = form.data('actor-type');
+                  if (actorCanBeRemoved(actortype, data, actors[actortype])) {
+                     e.preventDefault();
+                  }
+               });
+               form.on('select2:unselect', handleRemoveDeletebuttonForOne(actortypes[i], form));
+            }
             buttons_to_delete = removeAllDeleteButtons(buttons_to_delete);
 
             // as the ticket loading may be long, try to remove until 10s pass