-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use-sync-external-store
should be marked as a peerDep
#698
Comments
I see it's because We could mark it as peer dep, but that would require react users to install it. (some new package managers can do it automatically.) Curious, how "bad" is it to install |
thank you for your time. appreciate the response. But no thank you, installing react is an insurmountable sin I do not wish to commit. |
Does |
|
It could. (Theoretically, same applies to It's just a matter of usability. If we remove I feel like a dummy react library would help in your case. or dummy btw, we will be removing it in the future version. |
Oh this is fantastic news, looking forward to it! |
By the future version, I meant v2 with React >= 18 requirement. It won't happen very soon. |
Hi 👋🏻
We are using valtio in a context where react isnt used. So exclusively the
/vanilla
package.But NPM is throwing an install warning for us:
Believe its because valtio requires
use-sync-external-store
which has a peer dep on react, which we do not want.https://github.com/pmndrs/valtio/blob/7fe26c2a8ff2df8a5b8df019f8878dbf48e40876/package.json#LL140C18-L140C18
Perhaps there is an alternative to valtio that doesnt depend on react?
The text was updated successfully, but these errors were encountered: