New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code related to stream reading #51

Open

adrdc opened this issue Sep 13, 2021 · 0 comments · May be fixed by #52

Assignees

Contributor

adrdc commented Sep 13, 2021 •

edited

Loading

When initially writing the connector we tried a number of ways to read from a stream to see what worked best.
Including

SEGMENT_RANGE /* 1 split handles all segments within a stream cut */,
SEGMENT_RANGE_PER_SPLIT /* segments for stream cut are given out to different splits */,
EVENT_STREAM /* stream oriented reading (vs. segments) */,
SINGLE_GROUP_EVENT_STREAM /* stream oriented reading (vs. segments) all readers in same group */,

We settled 1 split per segment range as it performed the best (SEGMENT_RANGE_PER_SPLIT)

The dead/obsolete code should be removed.

adrdc self-assigned this

adrdc linked a pull request

that will close this issue

Issue 51: remove dead code #52

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment