Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent lookup for read/write data in CHT and FSI #107

Open
MakisH opened this issue Oct 24, 2022 · 0 comments
Open

Inconsistent lookup for read/write data in CHT and FSI #107

MakisH opened this issue Oct 24, 2022 · 0 comments
Assignees
Labels

Comments

@MakisH
Copy link
Member

MakisH commented Oct 24, 2022

For temperature and heat flux, we are checking whether the field name is exactly matched in the config:

if (isEqual(config->readDataNames[i], "Temperature")) {

For other fields, we are checking whether the field name just starts with this prefix (similar behavior as in the OpenFOAM adapter), sometimes with a trailing -, sometimes without:

precicec_createSolverInterface(participantName, adapterConfig.preciceConfigFilename, 0, 1);

} else if (startsWith(config->readDataNames[i], "Displacement")) {

Additionally, data names are hard-coded for preCICE:

interface->temperatureDataID = precicec_getDataID("Temperature", interface->nodesMeshID);

Finally, this error message is rather confusing:

printf("ERROR: Read data '%s' does not exist!\n", config->readDataNames[i]);

"Does not exist" made me think that I still needed to specify it somewhere. However, it just means that the adapter does not know how to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant