New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and move adapter.py #12

Open

3 tasks

MakisH opened this issue Jan 15, 2020 · 0 comments

Labels

Member

MakisH commented Jan 15, 2020 •

edited

Loading

The main adapter file is currently cht/adapter.py. We should:

Rename the adapter to something that points to preCICE, for example precice.py.
Move it to the main directory, unless we have any good reason not to. An important design decision would be if we:
1. implement FSI in the same file as CHT (preferably, if simple)
2. split CHT and FSI in a similar way as in the OpenFOAM adapter (preferably, if complex)
3. provide completely different adapters for CHT and FSI
Update the documentation respectively.

@uekerman what do you think about the name? Is there a good reason to keep this directory structure?

The text was updated successfully, but these errors were encountered:

MakisH added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment