Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the connectivity switch from the configuration, ask preCICE #198

Open
MakisH opened this issue Sep 20, 2021 · 1 comment
Open

Remove the connectivity switch from the configuration, ask preCICE #198

MakisH opened this issue Sep 20, 2021 · 1 comment
Labels
compatibility Affecting only specific OpenFOAM / preCICE versions enhancement Nice to have, but not a problem good first issue

Comments

@MakisH
Copy link
Member

MakisH commented Sep 20, 2021

preCICE v2.3.0 precice/precice#1080 introduces an API method to ask whether mesh connectivity is required. In the OpenFOAM adapter, we currently ask the user whether this is required, which the user should not need to configure, as it is system-internal information: https://precice.org/adapter-openfoam-config.html#nearest-projection-mapping

We could directly ask preCICE for this and remove the option from the configuration. As it currently defaults to false, maybe we can do it in a backwards-compatible way and deprecate the option for now.

@MakisH MakisH added enhancement Nice to have, but not a problem good first issue compatibility Affecting only specific OpenFOAM / preCICE versions labels Sep 20, 2021
@davidscn
Copy link
Member

This is not trivial to implement since the location type changes when we require mesh connectivity. We could hide this complexity from the user, but a separate coupling interface is preCICE-wise a must.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Affecting only specific OpenFOAM / preCICE versions enhancement Nice to have, but not a problem good first issue
Projects
None yet
Development

No branches or pull requests

2 participants