-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack v4 API inconsistencies #298
Comments
I really appreciate this issue. Thanks for the feedback @issacgerges. RE: First bullet RE: Second bullet |
No worries! I know one example is that plugins can (and sometimes do) manually add assets to the compilation, here's one such example, those usually only satisfy |
Thanks @issacgerges ! |
🎉 This issue has been resolved in version 2.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Bug description
There are some issues with this package that can cause problems when used with
webpack@4
webpack-sources
will bring in an additional version on most versions of webpack. These sources are passed back into the webpack compilationwebpack
v5, these source classes are available via thecompiler
(example)webpack
v4, I believe an explicit dependency is needed onwebpack-sources@1.4.3
to match the version used bywebpck/webpack
sourceAndMap
is not consistently present on compilation sources inv4
. This code should usesourceAndMap
when available and fallback to anull
map andsource.source()
(example)Reproduction
n/a
Node.js package manager
npm
Environment
Can you contribute a fix?
The text was updated successfully, but these errors were encountered: