Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow *_TOKEN naming convention #264

Open
20k-ultra opened this issue Oct 13, 2022 · 0 comments
Open

Follow *_TOKEN naming convention #264

20k-ultra opened this issue Oct 13, 2022 · 0 comments

Comments

@20k-ultra
Copy link

balena-io/deploy-to-balena-action#213 was created because flowzone uses a different secret name for the api authorization key. Looking at the other authorization secrets for services, they all follow *_TOKEN convention.

This isn't a big issue since Flowzone is doing the following translation:

 with:
          balena_token: ${{ secrets.BALENA_API_KEY || secrets.BALENA_API_KEY_PUSH }}

However, for repositories that are using the deploy-to-balena-action and switch to Flowzone or for some reason use Flowzone + deploy-to-balena-action in separate workflows, they now need to add the same value to their repo or org under BALENA_API_KEY AND BALENA_TOKEN. Therefore, given what other authorization secrets use for convention, Flowzone should change to using BALENA_TOKEN as its secret reference.

The benefit is repositories that switch to Flowzone and have secret: inherit no additional secrets are needed for this part of Flowzone to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant